Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: content/browser/renderer_host/render_widget_host_input_event_router.cc

Issue 2176373002: Don't create zero-velocity GestureFlingStarts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_input_event_router.h" 5 #include "content/browser/renderer_host/render_widget_host_input_event_router.h"
6 6
7 #include "base/debug/dump_without_crashing.h" 7 #include "base/debug/dump_without_crashing.h"
8 #include "cc/quads/surface_draw_quad.h" 8 #include "cc/quads/surface_draw_quad.h"
9 #include "cc/surfaces/surface_id_allocator.h" 9 #include "cc/surfaces/surface_id_allocator.h"
10 #include "cc/surfaces/surface_manager.h" 10 #include "cc/surfaces/surface_manager.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 // TODO(wjmaclean): Initialize latency info correctly for OOPIFs. 160 // TODO(wjmaclean): Initialize latency info correctly for OOPIFs.
161 // https://crbug.com/613628 161 // https://crbug.com/613628
162 ui::LatencyInfo latency_info; 162 ui::LatencyInfo latency_info;
163 target->ProcessMouseWheelEvent(*event, latency_info); 163 target->ProcessMouseWheelEvent(*event, latency_info);
164 } 164 }
165 165
166 void RenderWidgetHostInputEventRouter::RouteGestureEvent( 166 void RenderWidgetHostInputEventRouter::RouteGestureEvent(
167 RenderWidgetHostViewBase* root_view, 167 RenderWidgetHostViewBase* root_view,
168 blink::WebGestureEvent* event, 168 blink::WebGestureEvent* event,
169 const ui::LatencyInfo& latency) { 169 const ui::LatencyInfo& latency) {
170 DCHECK(event->type != blink::WebInputEvent::GestureFlingStart ||
171 event->data.flingStart.velocityX != 0.0 ||
172 event->data.flingStart.velocityY != 0.0);
173
170 switch (event->sourceDevice) { 174 switch (event->sourceDevice) {
171 case blink::WebGestureDeviceUninitialized: 175 case blink::WebGestureDeviceUninitialized:
172 NOTREACHED() << "Uninitialized device type is not allowed"; 176 NOTREACHED() << "Uninitialized device type is not allowed";
173 break; 177 break;
174 case blink::WebGestureDeviceTouchpad: 178 case blink::WebGestureDeviceTouchpad:
175 RouteTouchpadGestureEvent(root_view, event, latency); 179 RouteTouchpadGestureEvent(root_view, event, latency);
176 break; 180 break;
177 case blink::WebGestureDeviceTouchscreen: 181 case blink::WebGestureDeviceTouchscreen:
178 RouteTouchscreenGestureEvent(root_view, event, latency); 182 RouteTouchscreenGestureEvent(root_view, event, latency);
179 break; 183 break;
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 if (!touchpad_gesture_target_.target) 335 if (!touchpad_gesture_target_.target)
332 return; 336 return;
333 337
334 // TODO(mohsen): Add tests to check event location. 338 // TODO(mohsen): Add tests to check event location.
335 event->x += touchpad_gesture_target_.delta.x(); 339 event->x += touchpad_gesture_target_.delta.x();
336 event->y += touchpad_gesture_target_.delta.y(); 340 event->y += touchpad_gesture_target_.delta.y();
337 touchpad_gesture_target_.target->ProcessGestureEvent(*event, latency); 341 touchpad_gesture_target_.target->ProcessGestureEvent(*event, latency);
338 } 342 }
339 343
340 } // namespace content 344 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698