Dismiss editor UI when PaymentRequest is closing.

Dismiss editor UI when PaymentRequest is closing.

When PaymentRequest UI is closing, any open editor UI should also be
closed. Closing editor UI fires callbacks that should be ignored in this
case.

BUG=631130
Committed: https://crrev.com/6e47fdc9e09ff375fa3b0120fcf27ee27b8f5189
Cr-Commit-Position: refs/heads/master@{#407613}

[please use gerrit instead, 2016-07-25 18:23:07]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 18:23:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-25 18:25:03]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-07-25 18:25:04]

dfalcantara, ptal.

[gone, 2016-07-25 18:34:24]

https://codereview.chromium.org/2176273002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/2176273002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:949:
*  <li>User closing closing all incognito windows with PaymentRequest UI open in
an incognito
pizza pizza

https://codereview.chromium.org/2176273002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:956:
mEditorView.dismiss();
You need to check if the dialogs are showing to avoid a different crash.  See
PaymentRequestUI#dismissDialog()

[please use gerrit instead, 2016-07-25 20:39:06]

dfalcantara, ptal patch 3.

https://codereview.chromium.org/2176273002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/2176273002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:949:
*  <li>User closing closing all incognito windows with PaymentRequest UI open in
an incognito
On 2016/07/25 18:34:24, dfalcantara wrote:
> pizza pizza

Done.

https://codereview.chromium.org/2176273002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:956:
mEditorView.dismiss();
On 2016/07/25 18:34:24, dfalcantara wrote:
> You need to check if the dialogs are showing to avoid a different crash.  See
> PaymentRequestUI#dismissDialog()

Done.

[gone, 2016-07-25 20:40:59]

lgtm

[please use gerrit instead, 2016-07-25 21:11:34]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:12:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:12:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-25 22:15:45]

Description was changed from

==========
Dismiss editor UI when PaymentRequest is closing.

When PaymentRequest UI is closing, any open editor UI should also be
closed. Closing editor UI fires callbacks that should be ignored in this
case.

BUG=631130
==========

to

==========
Dismiss editor UI when PaymentRequest is closing.

When PaymentRequest UI is closing, any open editor UI should also be
closed. Closing editor UI fires callbacks that should be ignored in this
case.

BUG=631130

Committed: https://crrev.com/6e47fdc9e09ff375fa3b0120fcf27ee27b8f5189
Cr-Commit-Position: refs/heads/master@{#407613}
==========

[commit-bot: I haz the power, 2016-07-25 22:15:46]

Patchset 3 (id:??) landed as
https://crrev.com/6e47fdc9e09ff375fa3b0120fcf27ee27b8f5189
Cr-Commit-Position: refs/heads/master@{#407613}