Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3728)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Issue 2176273002: Dismiss editor UI when PaymentRequest is closing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
index c23d95fc02ae62482e74c8c1796c48394e3952db..3b2e95144dbd81781dd1eeecc1d71f6f76d9dfe3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
@@ -946,11 +946,15 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
* <li>Failure to process the payment.</li>
* <li>The JavaScript calling the abort() method in PaymentRequest API.</li>
* <li>The PaymentRequest JavaScript object being destroyed.</li>
+ * <li>User closing all incognito windows with PaymentRequest UI open in an incognito
+ * window.</li>
* </ul>
*/
@Override
public void onDismiss(DialogInterface dialog) {
mIsClosing = true;
+ if (mEditorView.isShowing()) mEditorView.dismiss();
+ if (mCardEditorView.isShowing()) mCardEditorView.dismiss();
if (sObserverForTest != null) sObserverForTest.onPaymentRequestDismiss();
if (!mIsClientClosing) mClient.onDismiss();
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698