Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2176133003: Fix memory leak in AndroidDeviceManager::HandlerThread. (Closed)

Created:
4 years, 5 months ago by Andrey Kraynov
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix memory leak in AndroidDeviceManager::HandlerThread. Thread object should be deleted after it stopped on IO thread. Committed: https://crrev.com/0131c2f732099c9c05ac1490129bb2b84122096e Cr-Commit-Position: refs/heads/master@{#407505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/devtools/device/android_device_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Andrey Kraynov
Hi! LeakSanitizer reported about possible memory leak, and it seems that |thread_| object should be ...
4 years, 5 months ago (2016-07-25 16:35:03 UTC) #2
dgozman
Thank you for fixing this! lgtm
4 years, 5 months ago (2016-07-25 16:47:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176133003/1
4 years, 5 months ago (2016-07-25 16:52:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 17:38:36 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 17:41:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0131c2f732099c9c05ac1490129bb2b84122096e
Cr-Commit-Position: refs/heads/master@{#407505}

Powered by Google App Engine
This is Rietveld 408576698