chrome/browser/devtools/device/android_device_manager.cc - Issue 2176133003: Fix memory leak in AndroidDeviceManager::HandlerThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/android_device_manager.cc

Issue 2176133003: Fix memory leak in AndroidDeviceManager::HandlerThread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/android_device_manager.cc

diff --git a/chrome/browser/devtools/device/android_device_manager.cc b/chrome/browser/devtools/device/android_device_manager.cc

index 8a1130d2508ed3efc900591e5cf4e3467536fafa..eb124881e08a5207edb3192784c6791ae94cbf45 100644

--- a/chrome/browser/devtools/device/android_device_manager.cc

+++ b/chrome/browser/devtools/device/android_device_manager.cc

@@ -489,6 +489,7 @@ AndroidDeviceManager::HandlerThread::message_loop() {

void AndroidDeviceManager::HandlerThread::StopThread(

base::Thread* thread) {

thread->Stop();

+ delete thread;

}

AndroidDeviceManager::HandlerThread::~HandlerThread() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »