Mac: Correct CALayer reuse logic

Mac: Correct CALayer reuse logic

This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.

With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.

A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.

BUG=618287
Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}
(cherry picked from commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731)

Committed: https://chromium.googlesource.com/chromium/src/+/09bcd556fc055ba67b6ea65d708d7c1ac3091ae1

[ccameron, 2016-07-25 21:53:55]

Description was changed from

==========
Mac: Correct CALayer reuse logic

This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.

With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.

A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.

BUG=618287

Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}
(cherry picked from commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731)
==========

to

==========
Mac: Correct CALayer reuse logic

This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.

With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.

A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.

BUG=618287

Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}
(cherry picked from commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731)

Committed:
https://chromium.googlesource.com/chromium/src/+/09bcd556fc055ba67b6ea65d708d...
==========

[ccameron, 2016-07-25 21:53:56]

Committed patchset #1 (id:1) manually as
09bcd556fc055ba67b6ea65d708d7c1ac3091ae1.