ui/accelerated_widget_mac/ca_renderer_layer_tree.mm - Issue 2176113003: Mac: Correct CALayer reuse logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

Issue 2176113003: Mac: Correct CALayer reuse logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

diff --git a/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm b/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

index feb283eaadef2ef7e1d03120c8ec30f6f2918364..7acd00ef7e6003eb668fef72a74c4d278746f81f 100644

--- a/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

+++ b/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

@@ -588,7 +588,10 @@ bool AVSampleBufferDisplayLayerEnqueueIOSurface(

ca_layer.reset([[CALayer alloc] init]);

}

[ca_layer setAnchorPoint:CGPointZero];

- [superlayer addSublayer:ca_layer];

+ if (old_layer && old_layer->ca_layer)

+ [superlayer replaceSublayer:old_layer->ca_layer with:ca_layer];

+ else

+ [superlayer addSublayer:ca_layer];

}

DCHECK_EQ([ca_layer superlayer], superlayer);

bool update_anything = update_contents || update_contents_rect ||

« no previous file with comments | « no previous file | no next file » | no next file with comments »