content/browser/renderer_host/render_view_host_browsertest.cc - Issue 2175933002: More aggressive IO asserts in content_browsertests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_browsertest.cc

Issue 2175933002: More aggressive IO asserts in content_browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use 1 less instance of ScopedAllowIO in DumpAccessibilityTestBase::RunTestForPlatform. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc ('k') | content/browser/tracing/tracing_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_browsertest.cc

diff --git a/content/browser/renderer_host/render_view_host_browsertest.cc b/content/browser/renderer_host/render_view_host_browsertest.cc

index e593e8f3c9c235547cff668b4214f4243b6ce324..9b260626a01a7fa5dd5d202ee4a108f9fc08e363 100644

--- a/content/browser/renderer_host/render_view_host_browsertest.cc

+++ b/content/browser/renderer_host/render_view_host_browsertest.cc

@@ -87,11 +87,7 @@ IN_PROC_BROWSER_TEST_F(RenderViewHostTest, BaseURLParam) {

EXPECT_EQ(1, observer.navigation_count());

// But should be set to the original page when reading MHTML.

- base::FilePath content_test_data_dir;

- ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &content_test_data_dir));

- test_url = net::FilePathToFileURL(

- content_test_data_dir.AppendASCII("google.mht"));

- NavigateToURL(shell(), test_url);

+ NavigateToURL(shell(), GetTestUrl(nullptr, "google.mht"));

EXPECT_EQ("http://www.google.com/", observer.base_url().spec());

}