content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc - Issue 2175933002: More aggressive IO asserts in content_browsertests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc

Issue 2175933002: More aggressive IO asserts in content_browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use 1 less instance of ScopedAllowIO in DumpAccessibilityTestBase::RunTestForPlatform. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/webrtc/webrtc_audio_debug_recordings_browsertest.cc ('k') | content/browser/renderer_host/render_view_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc

diff --git a/content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc b/content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc

index 255778590f65c7a3e1b392c800b725faef4b83e5..4e349a7c3855a76e74fb3967fe2ba9abcd023db3 100644

--- a/content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc

+++ b/content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc

@@ -9,6 +9,7 @@

#include "base/memory/ref_counted_memory.h"

#include "base/strings/stringprintf.h"

#include "base/test/trace_event_analyzer.h"

+#include "base/threading/thread_restrictions.h"

#include "base/trace_event/trace_event_impl.h"

#include "base/values.h"

#include "build/build_config.h"

@@ -102,7 +103,12 @@ class WebRtcGetUserMediaBrowserTest: public WebRtcContentBrowserTest {

void StopTracing() {

CHECK(message_loop_runner_.get() == NULL)

<< "Calling StopTracing more than once";

- trace_log_->SetDisabled();

+ {

+ base::ThreadRestrictions::ScopedAllowIO allow_thread_join_caused_by_test;

+ trace_log_->SetDisabled();

+ }

message_loop_runner_ = new MessageLoopRunner;

trace_log_->Flush(base::Bind(

&WebRtcGetUserMediaBrowserTest::OnTraceDataCollected,