third_party/WebKit/Source/devtools/front_end/ui/Widget.js - Issue 2175903002: DevTools: follow-up to view introduction, fix styles css.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Widget.js

Issue 2175903002: DevTools: follow-up to view introduction, fix styles css. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/sidebarPane.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/Widget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Widget.js b/third_party/WebKit/Source/devtools/front_end/ui/Widget.js

index e8f1b122757e6c398e684feba48b1fba910a3235..bed9940536a657292125376311ef65c51b4a2471 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Widget.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Widget.js

@@ -94,6 +94,8 @@ WebInspector.Widget.prototype = {

shouldHideOnDetach: function()

{

+ if (!this.element.parentElement)

+ return false;

if (this._hideOnDetach)

return true;

for (var child of this._children) {

@@ -694,6 +696,7 @@ WebInspector.VBoxWithResizeCallback.prototype = {

WebInspector.View = function(title, isWebComponent)

{

WebInspector.VBox.call(this, isWebComponent);

+ this.element.classList.add("view");

this._title = title;

/** @type {!Array<!WebInspector.ToolbarItem>} */

this._toolbarItems = [];