Chromium Code Reviews Chromium Code Reviews
Issue 2175863002:
Allow going fullscreen during a screen orientation change handler. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/fullscreen/full-screen-orientation-change.html |
| diff --git a/third_party/WebKit/LayoutTests/fullscreen/full-screen-orientation-change.html b/third_party/WebKit/LayoutTests/fullscreen/full-screen-orientation-change.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..fc75524a2d2e28c688bd7eaa3890d02616d92147 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fullscreen/full-screen-orientation-change.html |
| @@ -0,0 +1,27 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<title>Test that full screen requests are allowed when inside an orientation change handler.</title> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<span></span> |
| +<script> |
| + |
| +var element = document.querySelector('span'); |
| + |
| +async_test(function(t) { |
| + window.screen.orientation.onchange = function() { |
|
foolip
2016/07/23 00:33:54
wrap in t.step_func
mlamouri (slow - plz ping)
2016/07/25 15:54:18
Done.
|
| + element.webkitRequestFullScreen(); |
| + }; |
| + |
| + document.onwebkitfullscreenerror = t.step_func(function(e) { |
|
foolip
2016/07/23 00:33:54
Argument e is unused, assertunreached is missing a
mlamouri (slow - plz ping)
2016/07/25 15:54:18
Done.
|
| + assertunreached("fullscreen is not accepted when orientation is changed"); |
| + t.done(); |
| + }); |
| + |
| + document.onwebkitfullscreenchange = t.step_func_done(); |
| + window.testRunner.setMockScreenOrientation('landscape-primary'); |
| +}); |
| + |
| +</script> |
| +</body> |
|
foolip
2016/07/23 00:33:54
There's no explicit <body>, but in any case you ca
mlamouri (slow - plz ping)
2016/07/25 15:54:18
Done.
Sorry for the messy test. I should have tak
|
| +</html> |
