make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

remoting/protocol/channel_multiplexer.cc

Index: remoting/protocol/channel_multiplexer.cc
diff --git a/remoting/protocol/channel_multiplexer.cc b/remoting/protocol/channel_multiplexer.cc
index 2988f221ff34f4c0abdfc9d1517c480962dc4902..763779205fad5f5b9fdb77ae6772ef8f8731f36a 100644
--- a/remoting/protocol/channel_multiplexer.cc
+++ b/remoting/protocol/channel_multiplexer.cc
@@ -116,13 +116,13 @@ class ChannelMultiplexer::MuxSocket : public net::StreamSocket,
   virtual int Write(net::IOBuffer* buffer, int buffer_len,
                     const net::CompletionCallback& callback) OVERRIDE;
 
-  virtual bool SetReceiveBufferSize(int32 size) OVERRIDE {
+  virtual int SetReceiveBufferSize(int32 size) OVERRIDE {
     NOTIMPLEMENTED();
-    return false;
+    return net::ERR_NOT_IMPLEMENTED;

[wtc, 2014/03/29 13:30:12]

I also like net::ERR_NOT_IMPLEMENTED, but for consistency with the functions
below, let's use net::ERR_FAILED here and in SetSendBufferSize.

[jar (doing other things), 2014/04/01 23:50:39]

I switched the others to ERR_NOT_IMPLEMENTED, which seems much more correct.

I also correct the IsConnected() to return false (since it can't even connect!)

   }
-  virtual bool SetSendBufferSize(int32 size) OVERRIDE {
+  virtual int SetSendBufferSize(int32 size) OVERRIDE {
     NOTIMPLEMENTED();
-    return false;
+    return net::ERR_NOT_IMPLEMENTED;
   }
 
   virtual int Connect(const net::CompletionCallback& callback) OVERRIDE {