make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

remoting/protocol/channel_multiplexer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/channel_multiplexer.h"
 
 #include <string.h>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 98 matching lines @@
   void OnWriteComplete();
   void OnWriteFailed();
   void OnPacketReceived();
 
   // net::StreamSocket interface.
   virtual int Read(net::IOBuffer* buffer, int buffer_len,
                    const net::CompletionCallback& callback) OVERRIDE;
   virtual int Write(net::IOBuffer* buffer, int buffer_len,
                     const net::CompletionCallback& callback) OVERRIDE;
 
-  virtual bool SetReceiveBufferSize(int32 size) OVERRIDE {
+  virtual int SetReceiveBufferSize(int32 size) OVERRIDE {
     NOTIMPLEMENTED();
-    return false;
+    return net::ERR_NOT_IMPLEMENTED;

[wtc, 2014/03/29 13:30:12]

I also like net::ERR_NOT_IMPLEMENTED, but for consistency with the functions
below, let's use net::ERR_FAILED here and in SetSendBufferSize.

[jar (doing other things), 2014/04/01 23:50:39]

I switched the others to ERR_NOT_IMPLEMENTED, which seems much more correct.

I also correct the IsConnected() to return false (since it can't even connect!)

   }
-  virtual bool SetSendBufferSize(int32 size) OVERRIDE {
+  virtual int SetSendBufferSize(int32 size) OVERRIDE {
     NOTIMPLEMENTED();
-    return false;
+    return net::ERR_NOT_IMPLEMENTED;
   }
 
   virtual int Connect(const net::CompletionCallback& callback) OVERRIDE {
     NOTIMPLEMENTED();
     return net::ERR_FAILED;
   }
   virtual void Disconnect() OVERRIDE {
     NOTIMPLEMENTED();
   }
   virtual bool IsConnected() const OVERRIDE {
@@ skipping 374 matching lines @@
   channel->OnIncomingPacket(packet.Pass(), done_task);
 }
 
 bool ChannelMultiplexer::DoWrite(scoped_ptr<MultiplexPacket> packet,
                                  const base::Closure& done_task) {
   return writer_.Write(SerializeAndFrameMessage(*packet), done_task);
 }
 
 }  // namespace protocol
 }  // namespace remoting