WebGL 2: Fix nits when check vertexAttrib type with variable type in vertex shader

WebGL 2: Fix nits when check vertexAttrib type with variable type in vertex shader.

See the CL: https://codereview.chromium.org/2148723004

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cddee2c72b27a928a264263dad86ccc38dc1725b
Cr-Commit-Position: refs/heads/master@{#407303}

[yunchao, 2016-07-22 17:15:38]

Description was changed from

==========
Fix nits when check vertexAttrib type with variable type in vertex shader

BUG=628459
==========

to

==========
Fix nits when check vertexAttrib type with variable type in vertex shader

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-07-22 17:16:55]

Description was changed from

==========
Fix nits when check vertexAttrib type with variable type in vertex shader

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebGL 2: Fix nits when check vertexAttrib type with variable type in vertex
shader. 

See the CL: https://codereview.chromium.org/2148723004

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-07-22 17:21:58]

Patchset #1 (id:1) has been deleted

[yunchao, 2016-07-22 17:22:25]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 17:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-07-22 17:32:23]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2016-07-22 17:32:24]

PTAL. Thanks a lot!

Zhenyao, If you have one to fix the nits in you local machine, or this one
starts to fail against some bots, feel free to submit yours.

https://codereview.chromium.org/2175673003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/context_state.h (right):

https://codereview.chromium.org/2175673003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_state.h:250: packed_size +=
(max_vertex_attribs_ % 16 == 0) ? 0 : 1;
If you want to use ceil(), please don't forget to cast max_vertex_attribs_ or 16
to float.

[Zhenyao Mo, 2016-07-22 17:34:18]

Thank you.

LGTM

[commit-bot: I haz the power, 2016-07-22 18:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 18:15:59]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[yunchao, 2016-07-22 21:57:01]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-07-22 21:57:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 23:46:21]

Description was changed from

==========
WebGL 2: Fix nits when check vertexAttrib type with variable type in vertex
shader. 

See the CL: https://codereview.chromium.org/2148723004

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebGL 2: Fix nits when check vertexAttrib type with variable type in vertex
shader. 

See the CL: https://codereview.chromium.org/2148723004

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-22 23:46:24]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-07-22 23:47:38]

Description was changed from

==========
WebGL 2: Fix nits when check vertexAttrib type with variable type in vertex
shader. 

See the CL: https://codereview.chromium.org/2148723004

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
WebGL 2: Fix nits when check vertexAttrib type with variable type in vertex
shader.

See the CL: https://codereview.chromium.org/2148723004

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cddee2c72b27a928a264263dad86ccc38dc1725b
Cr-Commit-Position: refs/heads/master@{#407303}
==========

[commit-bot: I haz the power, 2016-07-22 23:47:39]

Patchset 1 (id:??) landed as
https://crrev.com/cddee2c72b27a928a264263dad86ccc38dc1725b
Cr-Commit-Position: refs/heads/master@{#407303}