Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2175673003: WebGL 2: Fix nits when check vertexAttrib type with variable type in vertex shader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index afee8ee3d7e4ac358241c26daef2ff8c34d073ed..50bd0f494250756eb08f9481d96156c8ee3c8c7a 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -9123,14 +9123,14 @@ bool GLES2DecoderImpl::AttribsTypeMatch() {
for (uint32_t index = 0; index < group_->max_vertex_attribs(); index += 16) {
uint32_t shader_attrib_written_mask =
state_.current_program->vertex_input_type_written_mask(index);
- uint32_t vao_attrib_written_mask =
- state_.vertex_attrib_manager->attrib_type_written_mask(index);
+ uint32_t vao_attrib_enabled_mask =
+ state_.vertex_attrib_manager->attrib_enabled_mask(index);
uint32_t vertex_attrib_base_type_mask =
- (~vao_attrib_written_mask &
- state_.GetGenericVertexAttribBaseTypeMask(index)) |
- (vao_attrib_written_mask &
- state_.vertex_attrib_manager->attrib_base_type_mask(index));
+ (~vao_attrib_enabled_mask &
+ state_.GetGenericVertexAttribBaseTypeMask(index)) |
+ (vao_attrib_enabled_mask &
+ state_.vertex_attrib_manager->attrib_base_type_mask(index));
if ((state_.current_program->vertex_input_base_type_mask(index)
& shader_attrib_written_mask) !=

Powered by Google App Engine
This is Rietveld 408576698