Issue 217553002: Revert 260213 "Relanding Switched main WebRTC browser tests to u..."

Issue 217553002: Revert 260213 "Relanding Switched main WebRTC browser tests to u..." (Closed)

Created:
6 years, 9 months ago by Charlie Reis

Modified:
6 years, 9 months ago

Reviewers:
phoglund_chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 260213 "Relanding Switched main WebRTC browser tests to u..." I suspect that this caused the VerifyEncryption failure here: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%283%29/builds/25821 > Relanding Switched main WebRTC browser tests to use a more realistic video > > > Switched main WebRTC browser tests to use a more realistic video. > > > After switching to fake device flags instead of software webcams, we > > noticed a ton of video-related metrics changed. This is because the > > spinning green ball is an unrealistic encode/decode example. This patch > > will use the new fake device file flag to play a more realistic video. > > > BUG=352261, 343504 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259887 > > TBR=tommi@chromium.org > BUG=352261, 343504 > > Review URL: https://codereview.chromium.org/216773002 TBR=phoglund@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260284

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -202 lines)			Patch
M	trunk/src/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/media/chrome_webrtc_browsertest.cc	View	12 chunks	+12 lines, -42 lines	0 comments	Download
M	trunk/src/chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/media/chrome_webrtc_typing_detection_browsertest.cc	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	trunk/src/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc	View	8 chunks	+61 lines, -13 lines	0 comments	Download
M	trunk/src/chrome/browser/media/webrtc_browsertest_base.cc	View	7 chunks	+16 lines, -17 lines	0 comments	Download
M	trunk/src/chrome/browser/media/webrtc_browsertest_common.h	View	2 chunks	+1 line, -22 lines	0 comments	Download
M	trunk/src/chrome/browser/media/webrtc_browsertest_common.cc	View	5 chunks	+6 lines, -77 lines	0 comments	Download
M	trunk/src/chrome/browser/media/webrtc_browsertest_perf.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/media/webrtc_browsertest_perf.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/test/data/webrtc/webrtc_jsep01_test.html	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

6 years, 9 months ago (2014-03-28 21:30:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r260284 (tree was closed).

Expand Messages | Collapse Messages