Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: chrome/android/BUILD.gn

Issue 2175413004: Enable whitelist generation for all builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index da3e6882753d2f7173ce61f2f3b6f566b9d642d1..dfe60c3ac1062c9a3d00872e3e96e9c9adb6ef82 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -264,6 +264,32 @@ action("chrome_android_java_google_api_keys_srcjar") {
]
}
+action("resource_whitelist") {
agrieve 2016/07/27 01:42:28 okay, I lied, I think this should go in //chrome/B
estevenson 2016/07/28 21:56:46 Done.
+ deps = [
+ "//chrome/android:chrome",
+ ]
+ script = "//tools/resources/generate_resource_whitelist.py"
+
+ infile = "$root_out_dir/libchrome.cr.so.whitelist"
agrieve 2016/07/27 01:42:28 nit: infile -> _infile
estevenson 2016/07/28 21:56:46 Done.
+ inputs = [
+ infile,
+ ]
+
+ outfile = "$root_out_dir/resource_whitelist.txt"
agrieve 2016/07/27 01:42:28 outfile->_outfile
estevenson 2016/07/28 21:56:46 Done.
+ outputs = [
+ outfile,
+ ]
+
+ args = [
+ "-i",
+ rebase_path(infile),
agrieve 2016/07/27 01:42:28 nit: for no good reason, convention is to use buil
estevenson 2016/07/28 21:56:46 Done.
+ "-o",
+ rebase_path(outfile),
+ "--out-dir",
+ rebase_path(root_build_dir),
agrieve 2016/07/27 01:42:28 You can just hardcode this as: --out-dir=.
estevenson 2016/07/28 21:56:46 Done.
+ ]
+}
+
java_cpp_enum("chrome_android_java_enums_srcjar") {
sources = [
"//chrome/browser/android/activity_type_ids.h",

Powered by Google App Engine
This is Rietveld 408576698