Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/android/BUILD.gn

Issue 2175413004: Enable whitelist generation for all builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 import("//build_overrides/v8.gni") 7 import("//build_overrides/v8.gni")
8 import("//chrome/android/chrome_public_apk_tmpl.gni") 8 import("//chrome/android/chrome_public_apk_tmpl.gni")
9 import("//chrome/common/features.gni") 9 import("//chrome/common/features.gni")
10 import("//chrome/version.gni") 10 import("//chrome/version.gni")
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 _output_path = "$target_gen_dir/$target_name.srcjar" 257 _output_path = "$target_gen_dir/$target_name.srcjar"
258 outputs = [ 258 outputs = [
259 _output_path, 259 _output_path,
260 ] 260 ]
261 args = [ 261 args = [
262 "--srcjar", 262 "--srcjar",
263 rebase_path(_output_path, root_build_dir), 263 rebase_path(_output_path, root_build_dir),
264 ] 264 ]
265 } 265 }
266 266
267 action("resource_whitelist") {
agrieve 2016/07/27 01:42:28 okay, I lied, I think this should go in //chrome/B
estevenson 2016/07/28 21:56:46 Done.
268 deps = [
269 "//chrome/android:chrome",
270 ]
271 script = "//tools/resources/generate_resource_whitelist.py"
272
273 infile = "$root_out_dir/libchrome.cr.so.whitelist"
agrieve 2016/07/27 01:42:28 nit: infile -> _infile
estevenson 2016/07/28 21:56:46 Done.
274 inputs = [
275 infile,
276 ]
277
278 outfile = "$root_out_dir/resource_whitelist.txt"
agrieve 2016/07/27 01:42:28 outfile->_outfile
estevenson 2016/07/28 21:56:46 Done.
279 outputs = [
280 outfile,
281 ]
282
283 args = [
284 "-i",
285 rebase_path(infile),
agrieve 2016/07/27 01:42:28 nit: for no good reason, convention is to use buil
estevenson 2016/07/28 21:56:46 Done.
286 "-o",
287 rebase_path(outfile),
288 "--out-dir",
289 rebase_path(root_build_dir),
agrieve 2016/07/27 01:42:28 You can just hardcode this as: --out-dir=.
estevenson 2016/07/28 21:56:46 Done.
290 ]
291 }
292
267 java_cpp_enum("chrome_android_java_enums_srcjar") { 293 java_cpp_enum("chrome_android_java_enums_srcjar") {
268 sources = [ 294 sources = [
269 "//chrome/browser/android/activity_type_ids.h", 295 "//chrome/browser/android/activity_type_ids.h",
270 "//chrome/browser/android/feedback/connectivity_checker.cc", 296 "//chrome/browser/android/feedback/connectivity_checker.cc",
271 "//chrome/browser/android/policy/policy_auditor.cc", 297 "//chrome/browser/android/policy/policy_auditor.cc",
272 "//chrome/browser/android/shortcut_info.h", 298 "//chrome/browser/android/shortcut_info.h",
273 "//chrome/browser/android/tab_android.h", 299 "//chrome/browser/android/tab_android.h",
274 "//chrome/browser/profiles/profile_metrics.h", 300 "//chrome/browser/profiles/profile_metrics.h",
275 "//chrome/browser/ui/android/infobars/infobar_android.h", 301 "//chrome/browser/ui/android/infobars/infobar_android.h",
276 ] 302 ]
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 apk_name = "ChromeSyncShellTest" 643 apk_name = "ChromeSyncShellTest"
618 apk_under_test = ":chrome_sync_shell_apk" 644 apk_under_test = ":chrome_sync_shell_apk"
619 android_manifest = chrome_sync_shell_test_apk_manifest 645 android_manifest = chrome_sync_shell_test_apk_manifest
620 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest" 646 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest"
621 deps = [ 647 deps = [
622 ":chrome_sync_shell_test_apk_java", 648 ":chrome_sync_shell_test_apk_java",
623 ] 649 ]
624 proguard_enabled = !is_java_debug 650 proguard_enabled = !is_java_debug
625 } 651 }
626 } 652 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698