Move Skia recipes from build repo

Move Skia recipes from build repo

BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002

Committed: https://skia.googlesource.com/skia/+/1ed2ae45f59c2864ea05838b4da2750b85472824

[borenet2, 2016-07-25 17:06:04]

Description was changed from

==========
Copy Skia recipes from build repo

BUG=skia:5563
==========

to

==========
Copy Skia recipes from build repo

BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002
==========

[borenet, 2016-07-26 15:06:20]

Description was changed from

==========
Copy Skia recipes from build repo

BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002
==========

to

==========
Move Skia recipes from build repo

BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002
==========

[borenet2, 2016-07-26 16:25:21]

borenet@chromium.org changed reviewers:
+ rmistry@google.com

[borenet2, 2016-07-26 16:25:23]

Patch set 1 just copies everything from build.git, so you should be able to
review by diffing against patch set 1.

[borenet2, 2016-07-26 16:25:35]

The CQ bit was checked by borenet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 16:25:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 16:28:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:28:11]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[borenet, 2016-07-26 16:51:21]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 16:51:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 16:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:54:02]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[borenet, 2016-07-26 16:57:59]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 16:58:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:00:32]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[borenet, 2016-07-26 17:03:57]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:04:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:06:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:06:51]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[borenet, 2016-07-26 17:41:04]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:41:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:53:41]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[rmistry, 2016-07-26 18:00:39]

https://codereview.chromium.org/2175373002/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2175373002/diff/40001/PRESUBMIT.py#newcode205
PRESUBMIT.py:205: results.extend(_RecipeSimulationTest(input_api, output_api))
How long does this take to run? should this only run if something in the
infra/bots directory changes?

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
File infra/bots/gen_buildbot_specs.py (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
infra/bots/gen_buildbot_specs.py:3: # Copyright 2015 The Chromium Authors. All
rights reserved.
2016?

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
infra/bots/gen_buildbot_specs.py:159: f.write('''# Copyright 2015 The Chromium
Authors. All rights reserved.
2016

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/skia/OWNERS (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/recipe_modul...
infra/bots/recipe_modules/skia/OWNERS:3: epoger@chromium.org
Remove epoger

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/recipes.py
File infra/bots/recipes.py (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/recipes.py#n...
infra/bots/recipes.py:14: #### PER-REPO CONFIGURATION (editable) ####
This file is very compact which is fine because it is a copy of the file on line
9. But can we make lines 14 to 19 have newlines and be slightly more readable?

https://codereview.chromium.org/2175373002/diff/40001/infra/config/recipes.cfg
File infra/config/recipes.cfg (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/config/recipes.cf...
infra/config/recipes.cfg:1: api_version: 1
Does their autoroller update this file?
Did we find out how often it will happen?

[borenet, 2016-07-26 18:08:45]

Uploaded patch set 11.

https://codereview.chromium.org/2175373002/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2175373002/diff/40001/PRESUBMIT.py#newcode205
PRESUBMIT.py:205: results.extend(_RecipeSimulationTest(input_api, output_api))
On 2016/07/26 18:00:38, rmistry wrote:
> How long does this take to run? should this only run if something in the
> infra/bots directory changes?

< 5 seconds.  I didn't notice a difference.

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
File infra/bots/gen_buildbot_specs.py (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
infra/bots/gen_buildbot_specs.py:3: # Copyright 2015 The Chromium Authors. All
rights reserved.
On 2016/07/26 18:00:38, rmistry wrote:
> 2016?

Not sure how this is supposed to work.  The file was written in 2015, and I'm
just copying it now.  Does that warrant updating the year?

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
infra/bots/gen_buildbot_specs.py:159: f.write('''# Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/07/26 18:00:38, rmistry wrote:
> 2016

Same question.

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/recipe_modul...
File infra/bots/recipe_modules/skia/OWNERS (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/recipe_modul...
infra/bots/recipe_modules/skia/OWNERS:3: epoger@chromium.org
On 2016/07/26 18:00:38, rmistry wrote:
> Remove epoger

Just removed the file, since it's not really needed in our own repo.

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/recipes.py
File infra/bots/recipes.py (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/recipes.py#n...
infra/bots/recipes.py:14: #### PER-REPO CONFIGURATION (editable) ####
On 2016/07/26 18:00:38, rmistry wrote:
> This file is very compact which is fine because it is a copy of the file on
line
> 9. But can we make lines 14 to 19 have newlines and be slightly more readable?

Sure, done.

https://codereview.chromium.org/2175373002/diff/40001/infra/config/recipes.cfg
File infra/config/recipes.cfg (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/config/recipes.cf...
infra/config/recipes.cfg:1: api_version: 1
On 2016/07/26 18:00:39, rmistry wrote:
> Does their autoroller update this file?
> Did we find out how often it will happen?

As of right now, no, because I haven't registered us to receive autorolls. 
According to the design doc, the average between June 7 2016 and June 22 2016
was 10 per day.  I'm going to wait to register us and instead limit us to manual
rolls until we nail down a good process.

[rmistry, 2016-07-26 18:20:03]

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
File infra/bots/gen_buildbot_specs.py (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
infra/bots/gen_buildbot_specs.py:3: # Copyright 2015 The Chromium Authors. All
rights reserved.
On 2016/07/26 18:08:45, borenet wrote:
> On 2016/07/26 18:00:38, rmistry wrote:
> > 2016?
> 
> Not sure how this is supposed to work.  The file was written in 2015, and I'm
> just copying it now.  Does that warrant updating the year?

No idea about copying files headers.

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
infra/bots/gen_buildbot_specs.py:159: f.write('''# Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/07/26 18:08:45, borenet wrote:
> On 2016/07/26 18:00:38, rmistry wrote:
> > 2016
> 
> Same question.

This should be updated because we want newly written files to have 2016.

https://codereview.chromium.org/2175373002/diff/40001/infra/config/recipes.cfg
File infra/config/recipes.cfg (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/config/recipes.cf...
infra/config/recipes.cfg:1: api_version: 1
On 2016/07/26 18:08:45, borenet wrote:
> On 2016/07/26 18:00:39, rmistry wrote:
> > Does their autoroller update this file?
> > Did we find out how often it will happen?
> 
> As of right now, no, because I haven't registered us to receive autorolls. 
> According to the design doc, the average between June 7 2016 and June 22 2016
> was 10 per day.  I'm going to wait to register us and instead limit us to
manual
> rolls until we nail down a good process.

SGTM

https://codereview.chromium.org/2175373002/diff/110001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2175373002/diff/110001/PRESUBMIT.py#newcode219
PRESUBMIT.py:219: # coverage installed.
Which coverage? python-coverage? we should install it then seems important to
run this both on upload and commit since people like me always skip presubmit
checks for upload.

https://codereview.chromium.org/2175373002/diff/110001/infra/bots/recipe_modu...
File infra/bots/recipe_modules/skia/api.py (right):

https://codereview.chromium.org/2175373002/diff/110001/infra/bots/recipe_modu...
infra/bots/recipe_modules/skia/api.py:345: # api.gclient.revert() assumes things
about the layout of the code, so it
Unfortunate

https://codereview.chromium.org/2175373002/diff/110001/infra/bots/upload_skps.py
File infra/bots/upload_skps.py (right):

https://codereview.chromium.org/2175373002/diff/110001/infra/bots/upload_skps...
infra/bots/upload_skps.py:54: # TODO(borenet): Upload to partner GS bucket?
Remove TODO.

[rmistry, 2016-07-26 18:20:28]

LGTM % comments

[borenet, 2016-07-26 18:29:31]

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
File infra/bots/gen_buildbot_specs.py (right):

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
infra/bots/gen_buildbot_specs.py:3: # Copyright 2015 The Chromium Authors. All
rights reserved.
On 2016/07/26 18:20:03, rmistry wrote:
> On 2016/07/26 18:08:45, borenet wrote:
> > On 2016/07/26 18:00:38, rmistry wrote:
> > > 2016?
> > 
> > Not sure how this is supposed to work.  The file was written in 2015, and
I'm
> > just copying it now.  Does that warrant updating the year?
> 
> No idea about copying files headers.

Joe says no update.

https://codereview.chromium.org/2175373002/diff/40001/infra/bots/gen_buildbot...
infra/bots/gen_buildbot_specs.py:159: f.write('''# Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/07/26 18:20:03, rmistry wrote:
> On 2016/07/26 18:08:45, borenet wrote:
> > On 2016/07/26 18:00:38, rmistry wrote:
> > > 2016
> > 
> > Same question.
> 
> This should be updated because we want newly written files to have 2016.

Done.

https://codereview.chromium.org/2175373002/diff/110001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2175373002/diff/110001/PRESUBMIT.py#newcode219
PRESUBMIT.py:219: # coverage installed.
On 2016/07/26 18:20:03, rmistry wrote:
> Which coverage? python-coverage? we should install it then seems important to
> run this both on upload and commit since people like me always skip presubmit
> checks for upload.

I think python-coverage. We don't control that bot though, so we'd need to talk
to chrome-infra.

https://codereview.chromium.org/2175373002/diff/110001/infra/bots/recipe_modu...
File infra/bots/recipe_modules/skia/api.py (right):

https://codereview.chromium.org/2175373002/diff/110001/infra/bots/recipe_modu...
infra/bots/recipe_modules/skia/api.py:345: # api.gclient.revert() assumes things
about the layout of the code, so it
On 2016/07/26 18:20:03, rmistry wrote:
> Unfortunate

Yep.

https://codereview.chromium.org/2175373002/diff/110001/infra/bots/upload_skps.py
File infra/bots/upload_skps.py (right):

https://codereview.chromium.org/2175373002/diff/110001/infra/bots/upload_skps...
infra/bots/upload_skps.py:54: # TODO(borenet): Upload to partner GS bucket?
On 2016/07/26 18:20:03, rmistry wrote:
> Remove TODO.

Done.

[borenet, 2016-07-26 18:30:45]

The CQ bit was checked by borenet@google.com

[borenet, 2016-07-26 18:30:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2175373002/#ps120001
(title: "Address more comments")

[commit-bot: I haz the power, 2016-07-26 18:30:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmistry, 2016-07-26 18:51:14]

https://codereview.chromium.org/2175373002/diff/110001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2175373002/diff/110001/PRESUBMIT.py#newcode219
PRESUBMIT.py:219: # coverage installed.
On 2016/07/26 18:29:31, borenet wrote:
> On 2016/07/26 18:20:03, rmistry wrote:
> > Which coverage? python-coverage? we should install it then seems important
to
> > run this both on upload and commit since people like me always skip
presubmit
> > checks for upload.
> 
> I think python-coverage. We don't control that bot though, so we'd need to
talk
> to chrome-infra.

They have bots that run coverage in presubmit so they do have a way to do it.
Not sure what that way is though.

[commit-bot: I haz the power, 2016-07-26 18:52:20]

Description was changed from

==========
Move Skia recipes from build repo

BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002
==========

to

==========
Move Skia recipes from build repo

BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002

Committed:
https://skia.googlesource.com/skia/+/1ed2ae45f59c2864ea05838b4da2750b85472824
==========

[commit-bot: I haz the power, 2016-07-26 18:52:22]

Committed patchset #12 (id:120001) as
https://skia.googlesource.com/skia/+/1ed2ae45f59c2864ea05838b4da2750b85472824