[Remoting Android] Define feedback animation size in dp

remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

Index: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
index 439eeab6d21644f38faa9a2f30daa45bccf665a7..5dd3bfe74603f70138590a7d21bc4d8423a8a817 100644
--- a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
+++ b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
@@ -31,16 +31,19 @@ public class GlDesktopView extends AbstractDesktopView implements SurfaceHolder.
     @Override
     public void showInputFeedback(InputFeedbackType feedbackToShow, Point pos) {
         float diameter;
-        // TODO(yuweih): diameter (and radius in DesktopView) should be defined in dp so that it is
-        // DPI independent.
         switch (feedbackToShow) {
-            case LARGE_ANIMATION:
-                diameter = 320.f;
-                break;
             case SMALL_ANIMATION:
-                diameter = 80.f;
+                diameter = 2 * getResources()
+                        .getDimensionPixelSize(R.dimen.feedback_animation_radius_small);

[joedow, 2016/07/25 20:24:18]

Why 2 * size?  Same comment about caching as the other animator plus add a
comment as to why the multiplier here.

[Yuwei, 2016/07/25 20:57:13]

That's because the OpenGL implementation takes diameter (since it is also the
width and height of the texture) as argument while what we set is the radius.

I'll add a comment about this.

[Yuwei, 2016/07/25 21:21:56]

Done. Added comment.

+                break;
+
+            case LARGE_ANIMATION:
+                diameter = 2 * getResources()
+                        .getDimensionPixelSize(R.dimen.feedback_animation_radius_large);
                 break;
+
             default:
+                assert false : "Unreached";
                 return;
         }
         float scaleFactor = mRenderData.transform.mapRadius(1);