[Remoting Android] Define feedback animation size in dp

remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.graphics.Point;
 import android.view.SurfaceHolder;
 
 import org.chromium.chromoting.jni.Client;
@@ skipping 13 matching lines @@
         super(desktop, client);
         Preconditions.notNull(display);
         mDisplay = display;
 
         getHolder().addCallback(this);
     }
 
     @Override
     public void showInputFeedback(InputFeedbackType feedbackToShow, Point pos) {
         float diameter;
-        // TODO(yuweih): diameter (and radius in DesktopView) should be defined in dp so that it is
-        // DPI independent.
         switch (feedbackToShow) {
+            case SMALL_ANIMATION:
+                diameter = 2 * getResources()
+                        .getDimensionPixelSize(R.dimen.feedback_animation_radius_small);

[joedow, 2016/07/25 20:24:18]

Why 2 * size?  Same comment about caching as the other animator plus add a
comment as to why the multiplier here.

[Yuwei, 2016/07/25 20:57:13]

That's because the OpenGL implementation takes diameter (since it is also the
width and height of the texture) as argument while what we set is the radius.

I'll add a comment about this.

[Yuwei, 2016/07/25 21:21:56]

Done. Added comment.

+                break;
+
             case LARGE_ANIMATION:
-                diameter = 320.f;
+                diameter = 2 * getResources()
+                        .getDimensionPixelSize(R.dimen.feedback_animation_radius_large);
                 break;
-            case SMALL_ANIMATION:
-                diameter = 80.f;
-                break;
+
             default:
+                assert false : "Unreached";
                 return;
         }
         float scaleFactor = mRenderData.transform.mapRadius(1);
         mDisplay.showCursorInputFeedback(pos.x, pos.y, diameter / scaleFactor);
     }
 
     @Override
     public void transformationChanged() {
         if (mRenderData.imageHeight == 0 || mRenderData.imageWidth == 0
                 || mRenderData.screenHeight == 0 || mRenderData.screenWidth == 0) {
@@ skipping 64 matching lines @@
     @Override
     public void surfaceDestroyed(SurfaceHolder holder) {
         // GlDisplay's life time spans to the whole session while GlDesktopView may be created and
         // destroyed for multiple times (say when the phone is rotated). It is important to remove
         // the listeners when the surface is about to be destroyed.
         mDisplay.onHostSizeChanged().remove(mOnHostSizeChangedListenerKey);
         mDisplay.onCanvasRendered().remove(mOnCanvasRenderedListenerKey);
         mDisplay.surfaceDestroyed();
     }
 }