Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1983)

Issue 2175343002: bot_update: improve UX when gclient is not configured. (Closed)

Created:
4 years, 4 months ago by tandrii(chromium)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

bot_update: improve UX when gclient is not configured. Instead of long stacktrace, explain what went wrong. R=sergiyb@chromium.org,andybons@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6da50398be9a06bbbd9640f30b2c53f96544d19b

Patch Set 1 #

Total comments: 2

Patch Set 2 : how about this? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M recipe_modules/bot_update/api.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
tandrii(chromium)
4 years, 4 months ago (2016-07-25 15:17:46 UTC) #1
Sergiy Byelozyorov
lgtm
4 years, 4 months ago (2016-07-25 15:19:27 UTC) #4
Bons
https://codereview.chromium.org/2175343002/diff/1/recipe_modules/bot_update/api.py File recipe_modules/bot_update/api.py (right): https://codereview.chromium.org/2175343002/diff/1/recipe_modules/bot_update/api.py#newcode82 recipe_modules/bot_update/api.py:82: 'gclient_config or configured in advance gclient module is required') ...
4 years, 4 months ago (2016-07-25 15:21:26 UTC) #7
tandrii(chromium)
https://codereview.chromium.org/2175343002/diff/1/recipe_modules/bot_update/api.py File recipe_modules/bot_update/api.py (right): https://codereview.chromium.org/2175343002/diff/1/recipe_modules/bot_update/api.py#newcode82 recipe_modules/bot_update/api.py:82: 'gclient_config or configured in advance gclient module is required') ...
4 years, 4 months ago (2016-07-25 15:32:04 UTC) #12
Bons
lgtm
4 years, 4 months ago (2016-07-25 15:33:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175343002/20001
4 years, 4 months ago (2016-07-25 15:33:43 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 15:36:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/6da50398be9a06...

Powered by Google App Engine
This is Rietveld 408576698