recipe_modules/bot_update/api.py - Issue 2175343002: bot_update: improve UX when gclient is not configured.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/bot_update/api.py

Issue 2175343002: bot_update: improve UX when gclient is not configured. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: how about this? Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/bot_update/api.py

diff --git a/recipe_modules/bot_update/api.py b/recipe_modules/bot_update/api.py

index 42cf3ec094b18b7041daaef21d87a2750ab19caf..7571d0dec2666f24c9665a46772ad4dea523b747 100644

--- a/recipe_modules/bot_update/api.py

+++ b/recipe_modules/bot_update/api.py

@@ -78,6 +78,8 @@ class BotUpdateApi(recipe_api.RecipeApi):

# We can re-use the gclient spec from the gclient module, since all the

# data bot_update needs is already configured into the gclient spec.

cfg = gclient_config or self.m.gclient.c

+ assert cfg is not None, (

+ 'missing gclient_config or forgot api.gclient.set_config(...) before?')

# Used by bot_update to determine if we want to run or not.

master = self._mastername

« no previous file with comments | « no previous file | no next file » | no next file with comments »