Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issue 2175313005: Revert of Sprinkle some release asserts over HTMLFrameElementBase (Closed)

Created:
2 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
2 years, 10 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sprinkle some release asserts over HTMLFrameElementBase (patchset #3 id:40001 of https://codereview.chromium.org/2169453002/ ) Reason for revert: Unflake bots Original issue's description: > Sprinkle some release asserts over HTMLFrameElementBase > > It appears to be difficult to get this right, but it's quite bad if we > get it wrong, so rather crash. > > BUG=628942 > R=dcheng@chromium.org > > Committed: https://crrev.com/b9e3d96067ff8c016d2505ab2a1f6b9d985c6b35 > Cr-Commit-Position: refs/heads/master@{#407430} TBR=dominicc@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628942 Committed: https://crrev.com/cd46b1e9ac4ea2d8f8492022dcb3638ef452f038 Cr-Commit-Position: refs/heads/master@{#407766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp View 4 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
Created Revert of Sprinkle some release asserts over HTMLFrameElementBase
2 years, 10 months ago (2016-07-26 09:55:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175313005/1
2 years, 10 months ago (2016-07-26 09:55:57 UTC) #3
dcheng
lgtm
2 years, 10 months ago (2016-07-26 11:01:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 10 months ago (2016-07-26 11:14:59 UTC) #5
commit-bot: I haz the power
2 years, 10 months ago (2016-07-26 11:16:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd46b1e9ac4ea2d8f8492022dcb3638ef452f038
Cr-Commit-Position: refs/heads/master@{#407766}

Powered by Google App Engine
This is Rietveld 408576698