Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2175163002: Merge "Ensure |m_image| is (re-)created in ImageResource::didAddClient()" (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge "Ensure |m_image| is (re-)created in ImageResource::didAddClient()" After ImageResource is pruned, |m_image| can be turned into null, but is not re-created when ResourceClient is added to ImageResource later. We re-create |m_image| when ImageResourceObserver is added in ImageResource::addObserver(). This CL do the same thing in ImageResource::didAddClient() to ensure |m_image| is non-null when ImageResource is reused after pruning. This is regression since ImageResourceClient was split into ResourceClient and ImageResourceObserver but the |m_image| re-creation logic was put only in the ImageResourceObserver path and not in the ResourceClient path: https://codereview.chromium.org/1706083002 https://codereview.chromium.org/1728313003 BUG=618597, 587663 TBR=mkwst@chromium.org, yhirano@chromium.org, hajimehoshi@chromium.org Review-Url: https://codereview.chromium.org/2141843003 Cr-Commit-Position: refs/heads/master@{#405024} (cherry picked from commit d415aad374ad81906840afbf4c05f0594f1f581b) Review URL: https://codereview.chromium.org/2169363002 . Cr-Commit-Position: refs/branch-heads/2785@{#290} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} (cherry picked from commit 79706ed327e0b6bb0ac98e7ae50c837fe049cce7) Committed: https://chromium.googlesource.com/chromium/src/+/e70486819d90b5bf2a01b0063c931ee3bc0ffbe1

Patch Set 1 #

Patch Set 2 : Fix merge error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -4 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 2 chunks +15 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hiroshige
4 years, 5 months ago (2016-07-24 13:01:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e70486819d90b5bf2a01b0063c931ee3bc0ffbe1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698