Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 2175163002: Merge "Ensure |m_image| is (re-)created in ImageResource::didAddClient()" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Fix merge error Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
index 788cb4aa7bf8c3acfb424e6cd5bde799ec4769a6..8342c15f71c3f36554801fd58e3261ff8d10d475 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
@@ -117,6 +117,20 @@ void ImageResource::markClientsAndObserversFinished()
Resource::markClientsAndObserversFinished();
}
+void ImageResource::ensureImage()
+{
+ if (m_data && !m_image && !errorOccurred()) {
+ createImage();
+ m_image->setData(m_data, true);
+ }
+}
+
+void ImageResource::didAddClient(ResourceClient* client)
+{
+ ensureImage();
+ Resource::didAddClient(client);
+}
+
void ImageResource::addObserver(ImageResourceObserver* observer)
{
willAddClientOrObserver();
@@ -126,10 +140,7 @@ void ImageResource::addObserver(ImageResourceObserver* observer)
if (!m_revalidatingRequest.isNull())
return;
- if (m_data && !m_image && !errorOccurred()) {
- createImage();
- m_image->setData(m_data, true);
- }
+ ensureImage();
if (m_image && !m_image->isNull()) {
observer->imageChanged(this);
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.h ('k') | third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698