Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2175113002: Re-enable IPCChannelMojoTest.SendFailWithPendingMessages (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable IPCChannelMojoTest.SendFailWithPendingMessages Simple fix, there's no need to quit the message loop on channel connection. If the expected error isn't encountered the test will hang. This seems sufficient and is not racy. BUG=630831 R=jam@chromium.org Committed: https://crrev.com/8c23d4643869946d5690720993d91955a26668f9 Cr-Commit-Position: refs/heads/master@{#407503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M ipc/ipc_channel_mojo_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ken Rockot(use gerrit already)
4 years, 5 months ago (2016-07-23 14:06:52 UTC) #1
jam
lgtm
4 years, 5 months ago (2016-07-25 16:56:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175113002/1
4 years, 5 months ago (2016-07-25 16:57:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 17:33:25 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 17:37:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c23d4643869946d5690720993d91955a26668f9
Cr-Commit-Position: refs/heads/master@{#407503}

Powered by Google App Engine
This is Rietveld 408576698