Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: ipc/ipc_channel_mojo_unittest.cc

Issue 2175113002: Re-enable IPCChannelMojoTest.SendFailWithPendingMessages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_mojo_unittest.cc
diff --git a/ipc/ipc_channel_mojo_unittest.cc b/ipc/ipc_channel_mojo_unittest.cc
index 41950d29a47d98016a684fa8b16336c3263ff9ac..de37658c26478d478a682747e46cbc62e93b9855 100644
--- a/ipc/ipc_channel_mojo_unittest.cc
+++ b/ipc/ipc_channel_mojo_unittest.cc
@@ -226,10 +226,6 @@ class ListenerExpectingErrors : public IPC::Listener {
public:
ListenerExpectingErrors() : has_error_(false) {}
- void OnChannelConnected(int32_t peer_pid) override {
- base::MessageLoop::current()->QuitWhenIdle();
- }
-
bool OnMessageReceived(const IPC::Message& message) override { return true; }
void OnChannelError() override {
@@ -265,8 +261,7 @@ DEFINE_IPC_CHANNEL_MOJO_TEST_CLIENT(IPCChannelMojoErraticTestClient,
Close();
}
-// Disabled because flake. http://crbug.com/630831
-TEST_F(IPCChannelMojoTest, DISABLED_SendFailWithPendingMessages) {
+TEST_F(IPCChannelMojoTest, SendFailWithPendingMessages) {
InitWithMojo("IPCChannelMojoErraticTestClient");
// Set up IPC channel and start client.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698