appengine/findit/handlers/build_failure.py - Issue 2175053002: [Findit] Fixing debug view UI not to bundle unclassified with reliable failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/handlers/build_failure.py

Issue 2175053002: [Findit] Fixing debug view UI not to bundle unclassified with reliable failures (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Fixing unit tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/handlers/build_failure.py

diff --git a/appengine/findit/handlers/build_failure.py b/appengine/findit/handlers/build_failure.py

index dc0c28e7380f21eace98ed7ddfeae6bc875bb525..288bbb86db9d4297d42989d88922408c48c420e5 100644

--- a/appengine/findit/handlers/build_failure.py

+++ b/appengine/findit/handlers/build_failure.py

@@ -253,7 +253,7 @@ def _GetAnalysisResultWithTryJobInfo(show_debug_info, organized_results,

if (('status' not in try_job_result or

try_job_result['status'] in NO_TRY_JOB_REASON_MAP.values()) or

- show_debug_info):

+ try_job_result.get('can_force')):

# There is no try job info but only heuristic result.

try_job_result['status'] = try_job_result.get(

'status', result_status.UNKNOWN)

@@ -361,7 +361,6 @@ class BuildFailure(BaseHandler):

show_debug_info, organized_results, *build_info)

data['analysis_result'] = analysis_result

return data

def HandleGet(self):

« no previous file with comments | « no previous file | appengine/findit/handlers/handlers_util.py » ('j') | no next file with comments »