[Findit] Fixing debug view UI not to bundle unclassified with reliable failures

appengine/findit/handlers/build_failure.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 from datetime import datetime
 
 from google.appengine.api import users
 
 from common import constants
@@ skipping 235 matching lines @@
               'suspected_cls': heuristic_result['suspected_cls']
           },
           'tests': tests if tests != [NON_SWARMING] else [],
           'first_failure': heuristic_result['first_failure'],
           'last_pass': heuristic_result['last_pass'],
           'supported': heuristic_result['supported']
       }
 
       if (('status' not in try_job_result or
            try_job_result['status'] in NO_TRY_JOB_REASON_MAP.values()) or
-          show_debug_info):
+          try_job_result.get('can_force')):
         # There is no try job info but only heuristic result.
         try_job_result['status'] = try_job_result.get(
             'status', result_status.UNKNOWN)
         step_updated_results['unclassified_failures'].append(final_result)
       elif try_job_result['status'] == result_status.FLAKY:
         step_updated_results['flaky_failures'].append(final_result)
       else:
         step_updated_results['reliable_failures'].append(final_result)
 
   return updated_results
@@ skipping 87 matching lines @@
                                   show_debug_info=False):
     data = self._PrepareCommonDataForFailure(analysis)
     data['status_message_map'] = result_status.STATUS_MESSAGE_MAP
 
     organized_results = _GetOrganizedAnalysisResultBySuspectedCL(
         analysis.result)
     analysis_result = _GetAnalysisResultWithTryJobInfo(
         show_debug_info, organized_results, *build_info)
 
     data['analysis_result'] = analysis_result
-
     return data
 
   def HandleGet(self):
     """Triggers analysis of a build failure on demand and return current result.
 
     If the final analysis result is available, set cache-control to 1 day to
     avoid overload by unnecessary and frequent query from clients; otherwise
     set cache-control to 5 seconds to allow repeated query.
 
     Serve HTML page or JSON result as requested.
@@ skipping 35 matching lines @@
       }
     else:
       return {
           'template': 'build_failure.html',
           'data': self._PrepareDataForTestFailures(analysis, build_info,
                                                    self._ShowDebugInfo()),
       }
 
   def HandlePost(self):  # pragma: no cover
     return self.HandleGet()