Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2864)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2174873002: Disable compilation symbols on goma builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 91f40810a826672c7062fc11c551e267711e51c6..79c79a42d21ad8fdb6f807ab5ae6990280b20693 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1487,7 +1487,10 @@ config("symbols") {
if (is_win) {
import("//build/toolchain/goma.gni")
if (use_goma) {
- cflags = [ "/Z7" ] # No PDB file
+ # Disable symbols during goma compilation because otherwise the redundant
+ # debug information (repeated in every .obj file) makes linker memory
+ # consumption and link times unsustainable (crbug.com/630074).
+ cflags = []
Dirk Pranke 2016/07/22 21:02:56 The implication of this change is that you can no
} else {
cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698