Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2174873002: Disable compilation symbols on goma builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1469 matching lines...) Expand 10 before | Expand all | Expand 10 after
1480 # default config and then adding the named one you want: 1480 # default config and then adding the named one you want:
1481 # 1481 #
1482 # configs -= [ "//build/config/compiler:default_symbols" ] 1482 # configs -= [ "//build/config/compiler:default_symbols" ]
1483 # configs += [ "//build/config/compiler:symbols" ] 1483 # configs += [ "//build/config/compiler:symbols" ]
1484 1484
1485 # Full symbols. 1485 # Full symbols.
1486 config("symbols") { 1486 config("symbols") {
1487 if (is_win) { 1487 if (is_win) {
1488 import("//build/toolchain/goma.gni") 1488 import("//build/toolchain/goma.gni")
1489 if (use_goma) { 1489 if (use_goma) {
1490 cflags = [ "/Z7" ] # No PDB file 1490 # Disable symbols during goma compilation because otherwise the redundant
1491 # debug information (repeated in every .obj file) makes linker memory
1492 # consumption and link times unsustainable (crbug.com/630074).
1493 cflags = []
Dirk Pranke 2016/07/22 21:02:56 The implication of this change is that you can no
1491 } else { 1494 } else {
1492 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue. 1495 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
1493 } 1496 }
1494 if (is_win_fastlink && visual_studio_version != "2013") { 1497 if (is_win_fastlink && visual_studio_version != "2013") {
1495 # Tell VS 2015+ to create a PDB that references debug 1498 # Tell VS 2015+ to create a PDB that references debug
1496 # information in .obj and .lib files instead of copying 1499 # information in .obj and .lib files instead of copying
1497 # it all. This flag is incompatible with /PROFILE 1500 # it all. This flag is incompatible with /PROFILE
1498 ldflags = [ "/DEBUG:FASTLINK" ] 1501 ldflags = [ "/DEBUG:FASTLINK" ]
1499 } else { 1502 } else {
1500 ldflags = [ "/DEBUG" ] 1503 ldflags = [ "/DEBUG" ]
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
1567 1570
1568 if (is_ios || is_mac) { 1571 if (is_ios || is_mac) {
1569 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1572 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1570 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1573 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1571 config("enable_arc") { 1574 config("enable_arc") {
1572 common_flags = [ "-fobjc-arc" ] 1575 common_flags = [ "-fobjc-arc" ]
1573 cflags_objc = common_flags 1576 cflags_objc = common_flags
1574 cflags_objcc = common_flags 1577 cflags_objcc = common_flags
1575 } 1578 }
1576 } 1579 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698