Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2174863003: DevTools: traverse widget hierarchy to reveal views. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, je_julie, lushnikov+blink_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: traverse widget hierarchy to reveal views. BUG=627306 Committed: https://crrev.com/9e24b26d47e63512104d10614bbf5b7b5efbf65c Cr-Commit-Position: refs/heads/master@{#407665}

Patch Set 1 #

Patch Set 2 : lcean #

Patch Set 3 : lcean #

Patch Set 4 : lcean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+559 lines, -658 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view-expected.txt View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/audits/audits-empty-stylesheet-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/audits/audits-panel-functional-expected.txt View 1 chunk +40 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt View 1 chunk +31 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-audits-api-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-audits-content-script-expected.txt View 1 chunk +41 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-audits-expected.txt View 1 chunk +39 lines, -39 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/reveal-objects.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 2 4 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 1 2 4 chunks +7 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js View 2 chunks +1 line, -24 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/auditResultTree.css View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 5 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 2 5 chunks +4 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 3 7 chunks +52 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js View 4 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js View 1 chunk +0 lines, -190 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/ui/ViewContainers.js View 1 2 3 1 chunk +220 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 1 2 3 chunks +19 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 3 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/sidebarPane.css View 1 chunk +0 lines, -93 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/ui/viewContainers.css View 3 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
pfeldman
4 years, 5 months ago (2016-07-22 23:05:21 UTC) #2
dgozman
lgtm
4 years, 4 months ago (2016-07-25 17:55:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174863003/60001
4 years, 4 months ago (2016-07-25 17:56:17 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/261513)
4 years, 4 months ago (2016-07-25 19:43:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174863003/60001
4 years, 4 months ago (2016-07-25 23:33:34 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-26 01:07:18 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 01:12:53 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9e24b26d47e63512104d10614bbf5b7b5efbf65c
Cr-Commit-Position: refs/heads/master@{#407665}

Powered by Google App Engine
This is Rietveld 408576698