Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2174863003: DevTools: traverse widget hierarchy to reveal views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
index 6c4c803ae23efb648d7be748dcefa6e149e4f465..ed0d4be3ccadb24ccadcc97d125d56624a9da96c 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
@@ -221,7 +221,7 @@ WebInspector.ElementsPanel.prototype = {
this._elementsSidebarViews.push(view);
if (this.sidebarPaneView)
- this.sidebarPaneView.addPane(view);
+ this.sidebarPaneView.appendView(view);
}
},
@@ -907,7 +907,7 @@ WebInspector.ElementsPanel.prototype = {
showMetrics.call(this, false);
}
- this.sidebarPaneView = new WebInspector.SidebarTabbedPane();
+ this.sidebarPaneView = new WebInspector.View.TabbedPaneContainer();
this.sidebarPaneView.element.addEventListener("contextmenu", this._sidebarContextMenuEventFired.bind(this), false);
if (this._popoverHelper)
this._popoverHelper.hidePopover();
@@ -918,8 +918,7 @@ WebInspector.ElementsPanel.prototype = {
this._splitWidget.installResizer(this.sidebarPaneView.headerElement());
var compositePane = new WebInspector.View(WebInspector.UIString("Styles"));
- compositePane.element.classList.add("composite");
- compositePane.element.classList.add("fill");
+ compositePane.element.classList.add("flex-auto");
var splitWidget = new WebInspector.SplitWidget(true, true, "stylesPaneSplitViewState", 215);
splitWidget.show(compositePane.element);
@@ -928,29 +927,29 @@ WebInspector.ElementsPanel.prototype = {
splitWidget.setSidebarWidget(computedStylePanesWrapper);
computedPane.show(computedStylePanesWrapper.element);
- this.sidebarPaneView.addPane(compositePane);
+ this.sidebarPaneView.appendView(compositePane);
} else {
var stylesPane = new WebInspector.View(WebInspector.UIString("Styles"));
- stylesPane.element.classList.add("composite", "fill", "metrics-and-styles");
+ stylesPane.element.classList.add("flex-auto", "metrics-and-styles");
matchedStylesContainer.show(stylesPane.element);
computedStylePanesWrapper.show(computedPane.element);
this.sidebarPaneView.addEventListener(WebInspector.TabbedPane.EventTypes.TabSelected, tabSelected, this);
- this.sidebarPaneView.addPane(stylesPane);
- this.sidebarPaneView.addPane(computedPane);
+ this.sidebarPaneView.appendView(stylesPane);
+ this.sidebarPaneView.appendView(computedPane);
}
this.sidebarPanes.styles.show(matchedStylePanesWrapper.element);
this.sidebarPanes.computedStyle.show(computedStylePanesWrapper.element);
showMetrics.call(this, horizontally);
- this.sidebarPaneView.addPane(this.sidebarPanes.eventListeners);
- this.sidebarPaneView.addPane(this.sidebarPanes.domBreakpoints);
- this.sidebarPaneView.addPane(this.sidebarPanes.properties);
+ this.sidebarPaneView.appendView(this.sidebarPanes.eventListeners);
+ this.sidebarPaneView.appendView(this.sidebarPanes.domBreakpoints);
+ this.sidebarPaneView.appendView(this.sidebarPanes.properties);
for (var sidebarViewWrapper of this._elementsSidebarViews)
- this.sidebarPaneView.addPane(sidebarViewWrapper);
+ this.sidebarPaneView.appendView(sidebarViewWrapper);
this._extensionSidebarPanesContainer = this.sidebarPaneView;
@@ -978,7 +977,7 @@ WebInspector.ElementsPanel.prototype = {
_addExtensionSidebarPane: function(pane)
{
if (pane.panelName() === this.name)
- this._extensionSidebarPanesContainer.addPane(pane);
+ this._extensionSidebarPanesContainer.appendView(pane);
},
__proto__: WebInspector.Panel.prototype

Powered by Google App Engine
This is Rietveld 408576698