Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2174853002:
[Mac/GN] Do not include unnecessary bundle data from //net. (Closed)
|
Created:
4 years, 5 months ago by Robert Sesek Modified:
4 years, 5 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac/GN] Do not include unnecessary bundle data from //net.
This only affects test targets and Content Shell.
R=sdefresne@chromium.org,mmenke@chromium.org
Committed: https://crrev.com/7d4ab4bc98046934113e510847dbb59e2666e7ee
Cr-Commit-Position: refs/heads/master@{#407190}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Address comments #Messages
Total messages: 28 (18 generated)
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On Mac, the data are found outside of the bundle, so these bundle_data steps are only needed on iOS.
lgtm https://codereview.chromium.org/2174853002/diff/1/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/2174853002/diff/1/net/BUILD.gn#newcode499 net/BUILD.gn:499: if (is_ios) { We generally define the bundle_data target on all platform (at least we do in the other files), so no need for is_ios here. https://codereview.chromium.org/2174853002/diff/1/net/BUILD.gn#newcode1322 net/BUILD.gn:1322: if (is_ios) { ditto https://codereview.chromium.org/2174853002/diff/1/net/BUILD.gn#newcode1555 net/BUILD.gn:1555: deps += [ ":net_unittests_bundle_data" ] nit: you could use bundle_deps instead to increase parallelism (no need to depend on those stamp to build the executable target) bundle_deps = [ ":net_unittests_bundle_data" ]
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks! https://codereview.chromium.org/2174853002/diff/1/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/2174853002/diff/1/net/BUILD.gn#newcode499 net/BUILD.gn:499: if (is_ios) { On 2016/07/22 15:36:48, sdefresne wrote: > We generally define the bundle_data target on all platform (at least we do in > the other files), so no need for is_ios here. Done. https://codereview.chromium.org/2174853002/diff/1/net/BUILD.gn#newcode1322 net/BUILD.gn:1322: if (is_ios) { On 2016/07/22 15:36:48, sdefresne wrote: > ditto Done. https://codereview.chromium.org/2174853002/diff/1/net/BUILD.gn#newcode1555 net/BUILD.gn:1555: deps += [ ":net_unittests_bundle_data" ] On 2016/07/22 15:36:48, sdefresne wrote: > nit: you could use bundle_deps instead to increase parallelism (no need to > depend on those stamp to build the executable target) > > bundle_deps = [ ":net_unittests_bundle_data" ] Good call. Done.
rsesek@chromium.org changed reviewers: + mmenke@chromium.org
+mmenke for OWNERS
On 2016/07/22 17:06:52, Robert Sesek wrote: > +mmenke for OWNERS This only affects tests, right? Perhaps mention that in the description.
Description was changed from ========== [Mac/GN] Do not include unnecessary bundle data from //net. R=sdefresne@chromium.org ========== to ========== [Mac/GN] Do not include unnecessary bundle data from //net. This only affects test targets and Content Shell. R=sdefresne@chromium.org ==========
Description was changed from ========== [Mac/GN] Do not include unnecessary bundle data from //net. This only affects test targets and Content Shell. R=sdefresne@chromium.org ========== to ========== [Mac/GN] Do not include unnecessary bundle data from //net. This only affects test targets and Content Shell. R=sdefresne@chromium.org,mmenke@chromium.org ==========
On 2016/07/22 17:14:42, mmenke wrote: > On 2016/07/22 17:06:52, Robert Sesek wrote: > > +mmenke for OWNERS > > This only affects tests, right? Perhaps mention that in the description. Right. Done.
On 2016/07/22 17:15:38, Robert Sesek wrote: > On 2016/07/22 17:14:42, mmenke wrote: > > On 2016/07/22 17:06:52, Robert Sesek wrote: > > > +mmenke for OWNERS > > > > This only affects tests, right? Perhaps mention that in the description. > > Right. Done. Thanks, LGTM!
The CQ bit was checked by rsesek@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2174853002/#ps40001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Do not include unnecessary bundle data from //net. This only affects test targets and Content Shell. R=sdefresne@chromium.org,mmenke@chromium.org ========== to ========== [Mac/GN] Do not include unnecessary bundle data from //net. This only affects test targets and Content Shell. R=sdefresne@chromium.org,mmenke@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Do not include unnecessary bundle data from //net. This only affects test targets and Content Shell. R=sdefresne@chromium.org,mmenke@chromium.org ========== to ========== [Mac/GN] Do not include unnecessary bundle data from //net. This only affects test targets and Content Shell. R=sdefresne@chromium.org,mmenke@chromium.org Committed: https://crrev.com/7d4ab4bc98046934113e510847dbb59e2666e7ee Cr-Commit-Position: refs/heads/master@{#407190} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7d4ab4bc98046934113e510847dbb59e2666e7ee Cr-Commit-Position: refs/heads/master@{#407190} |
