Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: net/BUILD.gn

Issue 2174853002: [Mac/GN] Do not include unnecessary bundle data from //net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index ef793f70c23a3fd665e1ea46f8b87ca956f1cd60..4f8128733876f78230eda7b5770e7639992b19a4 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -629,15 +629,15 @@ static_library("test_support") {
"//url",
]
- deps = [
- ":test_support_bundle_data",
- ]
+ deps = []
data = [
"data/",
]
- if (!is_ios) {
+ if (is_ios) {
+ deps += [ ":test_support_bundle_data" ]
+ } else {
public_deps += [ "//third_party/protobuf:py_proto" ]
}
@@ -1339,7 +1339,6 @@ test("net_unittests") {
":balsa",
":extras",
":net",
- ":net_unittests_bundle_data",
":simple_quic_tools",
":stale_while_revalidate_experiment_domains",
":test_support",
@@ -1546,6 +1545,8 @@ test("net_unittests") {
"socket/unix_domain_client_socket_posix_unittest.cc",
"socket/unix_domain_server_socket_posix_unittest.cc",
]
+
+ bundle_deps = [ ":net_unittests_bundle_data" ]
}
# Unit tests that aren't supported by the current ICU alternatives on Android.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698