Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

This CL removes GTEST_LANG_CXX11=0 from build configuration, and let
gtest detect whether C++11 is available. And to make it work, this CL
injects a custom gmock-port.h to provide missing type_traits.

BUG=630299
Committed: https://crrev.com/6a1547324ce34c4b6779eb906fa9622e0b903afb
Cr-Commit-Position: refs/heads/master@{#407360}

[tzik, 2016-07-22 05:00:08]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 05:00:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 06:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 06:24:07]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-07-22 07:10:33]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 07:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-22 08:20:19]

Description was changed from

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

BUG=630299
==========

to

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

BUG=630299
==========

[tzik, 2016-07-22 08:20:19]

tzik@chromium.org changed reviewers:
+ sadrul@chromium.org, thakis@chromium.org, wez@chromium.org

[tzik, 2016-07-22 08:21:25]

tzik@chromium.org changed reviewers:
+ dpranke@chromium.org
- thakis@chromium.org

[tzik, 2016-07-22 08:22:58]

Description was changed from

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

BUG=630299
==========

to

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock



BUG=630299
==========

[tzik, 2016-07-22 08:22:58]

tzik@chromium.org changed reviewers:
+ danakj@chromium.org

[tzik, 2016-07-22 08:25:47]

Description was changed from

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock



BUG=630299
==========

to

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

This CL removes GTEST_LANG_CXX11=0 from build configuration, and let
gtest detect C++11 is available. And to make it work, this CL injects a
custom gmock-port.h to provide missing type_traits.

BUG=630299
==========

[tzik, 2016-07-22 08:25:58]

PTAL

[commit-bot: I haz the power, 2016-07-22 09:17:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:17:50]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-07-22 11:08:18]

Description was changed from

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

This CL removes GTEST_LANG_CXX11=0 from build configuration, and let
gtest detect C++11 is available. And to make it work, this CL injects a
custom gmock-port.h to provide missing type_traits.

BUG=630299
==========

to

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

This CL removes GTEST_LANG_CXX11=0 from build configuration, and let
gtest detect whether C++11 is available. And to make it work, this CL
injects a custom gmock-port.h to provide missing type_traits.

BUG=630299
==========

[Dirk Pranke, 2016-07-22 16:29:03]

lgtm

https://codereview.chromium.org/2174663002/diff/20001/build/secondary/testing...
File build/secondary/testing/gmock/BUILD.gn (right):

https://codereview.chromium.org/2174663002/diff/20001/build/secondary/testing...
build/secondary/testing/gmock/BUILD.gn:8: "../gmock_custom",
does this work as "//testing/gmock_custom" instead? Using ".." is somewhat
unconventional.

[tzik, 2016-07-22 16:47:45]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 16:48:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-22 16:48:21]

https://codereview.chromium.org/2174663002/diff/20001/build/secondary/testing...
File build/secondary/testing/gmock/BUILD.gn (right):

https://codereview.chromium.org/2174663002/diff/20001/build/secondary/testing...
build/secondary/testing/gmock/BUILD.gn:8: "../gmock_custom",
On 2016/07/22 16:29:02, Dirk Pranke wrote:
> does this work as "//testing/gmock_custom" instead? Using ".." is somewhat
> unconventional.

Done.

[tzik, 2016-07-22 18:11:12]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 18:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2016-07-22 18:39:18]

wez@chromium.org changed reviewers:
+ sergeyu@chromium.org
- wez@chromium.org

[Wez, 2016-07-22 18:39:19]

-me, +sergeyu

[danakj, 2016-07-22 18:47:27]

LGTM

[Sergey Ulanov, 2016-07-22 18:53:08]

lgtm

[commit-bot: I haz the power, 2016-07-22 19:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 19:23:55]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-07-23 00:59:57]

lgtm

[tzik, 2016-07-23 08:33:49]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-07-23 08:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2174663002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-23 08:34:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 08:37:23]

Description was changed from

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

This CL removes GTEST_LANG_CXX11=0 from build configuration, and let
gtest detect whether C++11 is available. And to make it work, this CL
injects a custom gmock-port.h to provide missing type_traits.

BUG=630299
==========

to

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

This CL removes GTEST_LANG_CXX11=0 from build configuration, and let
gtest detect whether C++11 is available. And to make it work, this CL
injects a custom gmock-port.h to provide missing type_traits.

BUG=630299
==========

[commit-bot: I haz the power, 2016-07-23 08:37:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-23 08:38:38]

Description was changed from

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

This CL removes GTEST_LANG_CXX11=0 from build configuration, and let
gtest detect whether C++11 is available. And to make it work, this CL
injects a custom gmock-port.h to provide missing type_traits.

BUG=630299
==========

to

==========
Remove GTEST_LANG_CXX11 and switch to C++11 on gtest and gmock

This CL removes GTEST_LANG_CXX11=0 from build configuration, and let
gtest detect whether C++11 is available. And to make it work, this CL
injects a custom gmock-port.h to provide missing type_traits.

BUG=630299

Committed: https://crrev.com/6a1547324ce34c4b6779eb906fa9622e0b903afb
Cr-Commit-Position: refs/heads/master@{#407360}
==========

[commit-bot: I haz the power, 2016-07-23 08:38:40]

Patchset 4 (id:??) landed as
https://crrev.com/6a1547324ce34c4b6779eb906fa9622e0b903afb
Cr-Commit-Position: refs/heads/master@{#407360}

[Michael Achenbach, 2016-07-25 07:01:32]

This breaks v8 on linux (gn bots):
https://codereview.chromium.org/2180823002/

Any hint how we can fix this?

[tzik, 2016-07-25 11:00:02]

V8 seems to have its own gtest / gmock configuration that needs to be
updated.
PTAL to https://codereview.chromium.org/2179743002/

2016-07-25 16:01 GMT+09:00 <machenbach@chromium.org>:

> This breaks v8 on linux (gn bots):
> https://codereview.chromium.org/2180823002/
>
> Any hint how we can fix this?
>
> https://codereview.chromium.org/2174663002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.