Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2174563002: Add UMA for launcher shortcuts and update AndroidManifest.xml (Closed)

Created:
4 years, 5 months ago by Theresa
Modified:
4 years, 5 months ago
Reviewers:
Ted C, rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA for launcher shortcuts and update AndroidManifest.xml Record user actions when intents from launcher shortcuts are received. Also, update AndroidManifest.xml to use an sdk version number rather than a codename. BUG=629149 Committed: https://crrev.com/83d536b45781a7813ae07f015a7b00a0c8b634ca Cr-Commit-Position: refs/heads/master@{#407530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/LauncherShortcutActivity.java View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Theresa
ptal
4 years, 5 months ago (2016-07-21 22:43:19 UTC) #4
Ted C
lgtm
4 years, 5 months ago (2016-07-21 23:12:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174563002/1
4 years, 5 months ago (2016-07-21 23:15:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/222847)
4 years, 5 months ago (2016-07-21 23:23:52 UTC) #10
Theresa
+rkaplow for actions.xml
4 years, 5 months ago (2016-07-21 23:30:29 UTC) #12
rkaplow
lgtm
4 years, 5 months ago (2016-07-25 17:56:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174563002/1
4 years, 5 months ago (2016-07-25 18:14:17 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 18:49:11 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 18:55:43 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83d536b45781a7813ae07f015a7b00a0c8b634ca
Cr-Commit-Position: refs/heads/master@{#407530}

Powered by Google App Engine
This is Rietveld 408576698