Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2174563002: Add UMA for launcher shortcuts and update AndroidManifest.xml (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 67a5265730324d443f6372dd642622c4a8520d42..9dcd3e26ae01e10e9b9bc5de998889ac2d5d47f8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -714,6 +714,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
TabOpenType tabOpenType, String externalAppId, int tabIdToBringToFront,
boolean hasUserGesture, Intent intent) {
TabModel tabModel = getCurrentTabModel();
+ boolean fromLauncherShortcut = IntentUtils.safeGetBooleanExtra(
+ intent, IntentHandler.EXTRA_INVOKED_FROM_SHORTCUT, false);
switch (tabOpenType) {
case REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB:
// Used by the bookmarks application.
@@ -778,10 +780,12 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
openNewTab(url, referer, headers, externalAppId, intent, false);
break;
case OPEN_NEW_TAB:
+ if (fromLauncherShortcut) recordLauncherShortcutAction(false);
openNewTab(url, referer, headers, externalAppId, intent, true);
break;
case OPEN_NEW_INCOGNITO_TAB:
if (url == null || url.equals(UrlConstants.NTP_URL)) {
+ if (fromLauncherShortcut) recordLauncherShortcutAction(true);
if (TextUtils.equals(externalAppId, getPackageName())) {
// Used by the Account management screen to open a new incognito tab.
// Account management screen collects its metrics separately.
@@ -1112,6 +1116,14 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
action, BACK_PRESSED_COUNT);
}
+ private void recordLauncherShortcutAction(boolean isIncognito) {
+ if (isIncognito) {
+ RecordUserAction.record("Android.LauncherShortcut.NewIncognitoTab");
+ } else {
+ RecordUserAction.record("Android.LauncherShortcut.NewTab");
+ }
+ }
+
private void moveTabToOtherWindow(Tab tab) {
Class<? extends Activity> targetActivity =
MultiWindowUtils.getInstance().getOpenInOtherWindowActivity(this);
« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698