Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2174513002: Remove unused CJS_Value::Attach() variant (Closed)

Created:
4 years, 5 months ago by Tom Sepez
Modified:
4 years, 5 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused CJS_Value::Attach() variant Committed: https://pdfium.googlesource.com/pdfium/+/d780735def22c4c2ec3a0cc89856c86486c25494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M fpdfsdk/javascript/JS_Value.h View 2 chunks +2 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
dsinclair, trivial review.
4 years, 5 months ago (2016-07-21 21:48:51 UTC) #4
dsinclair
lgtm
4 years, 5 months ago (2016-07-25 13:59:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174513002/1
4 years, 5 months ago (2016-07-25 13:59:34 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 14:26:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d780735def22c4c2ec3a0cc89856c86486c2...

Powered by Google App Engine
This is Rietveld 408576698