Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: fpdfsdk/javascript/JS_Value.cpp

Issue 2174513002: Remove unused CJS_Value::Attach() variant (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/javascript/JS_Value.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/JS_Value.cpp
diff --git a/fpdfsdk/javascript/JS_Value.cpp b/fpdfsdk/javascript/JS_Value.cpp
index 5c1ba2a432281035ca3675d1540512aa69ea262c..c13d1d405e54a412d0a7ba135c52848bf226f8aa 100644
--- a/fpdfsdk/javascript/JS_Value.cpp
+++ b/fpdfsdk/javascript/JS_Value.cpp
@@ -75,11 +75,6 @@ void CJS_Value::Attach(v8::Local<v8::Value> pValue) {
m_pValue = pValue;
}
-void CJS_Value::Attach(CJS_Value* pValue) {
- if (pValue)
- Attach(pValue->ToV8Value());
-}
-
void CJS_Value::Detach() {
m_pValue = v8::Local<v8::Value>();
}
« no previous file with comments | « fpdfsdk/javascript/JS_Value.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698