Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2174423005: Fix for false positive in field (not-)overriding. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for false positive in field (not-)overriding. Fields can also override setters. R=pquitslund@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cc290c1dc0081e0910ef79635389421493bdbd02

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -16 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +8 lines, -8 lines 3 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 1 chunk +18 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 4 months ago (2016-07-26 00:58:02 UTC) #1
pquitslund
lgtm https://codereview.chromium.org/2174423005/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/2174423005/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode5170 pkg/analyzer/lib/src/generated/resolver.dart:5170: if (!(_getOverriddenMember(getter) != null || Is it possible ...
4 years, 4 months ago (2016-07-26 05:32:50 UTC) #2
scheglov
https://codereview.chromium.org/2174423005/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/2174423005/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode5170 pkg/analyzer/lib/src/generated/resolver.dart:5170: if (!(_getOverriddenMember(getter) != null || On 2016/07/26 05:32:49, pquitslund ...
4 years, 4 months ago (2016-07-26 05:48:23 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as cc290c1dc0081e0910ef79635389421493bdbd02 (presubmit successful).
4 years, 4 months ago (2016-07-26 05:49:09 UTC) #5
Brian Wilkerson
4 years, 4 months ago (2016-07-27 14:24:42 UTC) #6
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2174423005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2174423005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:5170: if
(!(_getOverriddenMember(getter) != null ||
I'd rather that we just make other parts of analyzer work correctly...

Powered by Google App Engine
This is Rietveld 408576698