Fix for false positive in field (not-)overriding.

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.resolver;
 
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
@@ skipping 5123 matching lines @@
         }
       }
     }
   }
 }
 
 /**
  * Instances of the class `OverrideVerifier` visit all of the declarations in a compilation
  * unit to verify that if they have an override annotation it is being used correctly.
  */
-class OverrideVerifier extends RecursiveAstVisitor<Object> {
+class OverrideVerifier extends RecursiveAstVisitor {
   /**
    * The error reporter used to report errors.
    */
   final ErrorReporter _errorReporter;
 
   /**
    * The inheritance manager used to find overridden methods.
    */
   final InheritanceManager _manager;
 
   /**
    * Initialize a newly created verifier to look for inappropriate uses of the override annotation.
    *
    * @param errorReporter the error reporter used to report errors
    * @param manager the inheritance manager used to find overridden methods
    */
   OverrideVerifier(this._errorReporter, this._manager);
 
   @override
-  Object visitFieldDeclaration(FieldDeclaration node) {
+  visitFieldDeclaration(FieldDeclaration node) {
     for (VariableDeclaration field in node.fields.variables) {
       VariableElement fieldElement = field.element;
       if (fieldElement is FieldElement && _isOverride(fieldElement)) {
-        PropertyAccessorElement getterElement = fieldElement.getter;
-        if (_getOverriddenMember(getterElement) == null) {
+        PropertyAccessorElement getter = fieldElement.getter;
+        PropertyAccessorElement setter = fieldElement.setter;
+        if (!(_getOverriddenMember(getter) != null ||

[pquitslund, 2016/07/26 05:32:49]

Is it possible for `getter` to be null here?  Do we need to test?

[scheglov, 2016/07/26 05:48:23]

If other parts of analyzer work correctly, there should always be `getter`.
But maybe we should check anyway...

[Brian Wilkerson, 2016/07/27 14:24:41]

I'd rather that we just make other parts of analyzer work correctly...

+            setter != null && _getOverriddenMember(setter) != null)) {
           _errorReporter.reportErrorForNode(
-              HintCode.OVERRIDE_ON_NON_OVERRIDING_GETTER, field.name);
+              HintCode.OVERRIDE_ON_NON_OVERRIDING_FIELD, field.name);
         }
       }
     }
-    return super.visitFieldDeclaration(node);
   }
 
   @override
-  Object visitMethodDeclaration(MethodDeclaration node) {
+  visitMethodDeclaration(MethodDeclaration node) {
     ExecutableElement element = node.element;
     if (_isOverride(element)) {
       if (_getOverriddenMember(element) == null) {
         if (element is MethodElement) {
           _errorReporter.reportErrorForNode(
               HintCode.OVERRIDE_ON_NON_OVERRIDING_METHOD, node.name);
         } else if (element is PropertyAccessorElement) {
           if (element.isGetter) {
             _errorReporter.reportErrorForNode(
                 HintCode.OVERRIDE_ON_NON_OVERRIDING_GETTER, node.name);
           } else {
             _errorReporter.reportErrorForNode(
                 HintCode.OVERRIDE_ON_NON_OVERRIDING_SETTER, node.name);
           }
         }
       }
     }
-    return super.visitMethodDeclaration(node);
   }
 
   /**
    * Return the member that overrides the given member.
    *
    * @param member the member that overrides the returned member
    * @return the member that overrides the given member
    */
   ExecutableElement _getOverriddenMember(ExecutableElement member) {
     LibraryElement library = member.library;
@@ skipping 5881 matching lines @@
       return null;
     }
     if (identical(node.staticElement, variable)) {
       if (node.inSetterContext()) {
         result = true;
       }
     }
     return null;
   }
 }