Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2174423004: Add page load metrics for no-store forward back navigations. (Closed)

Created:
4 years, 4 months ago by Charlie Harrison
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, Charlie Reis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add page load metricsfor no-store forward back navigations. This patch adds support in NavigationHandle to retrieve http response headers. This data is used by the page_load_metrics system to separate out histograms for no-store back/forward navigations. BUG=631309 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/be78b7813aa8753f94871792fb0e80090a535c89 Cr-Commit-Position: refs/heads/master@{#409907}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add page load metricsfor no-store forward back navigations. #

Patch Set 4 : Update histograms.xml and add another histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 1 2 3 9 chunks +34 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/navigation_handle.h View 2 chunks +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (23 generated)
Charlie Harrison
cc creis Here's the review plumbing const http headers into the content public api for ...
4 years, 4 months ago (2016-08-02 18:02:35 UTC) #18
nasko
content/ LGTM
4 years, 4 months ago (2016-08-03 16:51:26 UTC) #21
Charlie Harrison
Thanks nasko! +shivanisha for PLM and holte@ for histograms.xml
4 years, 4 months ago (2016-08-03 17:00:33 UTC) #23
Steven Holte
lgtm
4 years, 4 months ago (2016-08-03 19:07:41 UTC) #24
shivanisha
On 2016/08/03 at 19:07:41, holte wrote: > lgtm lgtm
4 years, 4 months ago (2016-08-04 19:10:30 UTC) #25
Charlie Harrison
Thanks, all.
4 years, 4 months ago (2016-08-04 19:11:21 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174423004/60001
4 years, 4 months ago (2016-08-04 19:13:42 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-04 21:45:23 UTC) #30
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 21:47:00 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/be78b7813aa8753f94871792fb0e80090a535c89
Cr-Commit-Position: refs/heads/master@{#409907}

Powered by Google App Engine
This is Rietveld 408576698