content/browser/frame_host/navigation_handle_impl.cc - Issue 2174423004: Add page load metrics for no-store forward back navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2174423004: Add page load metrics for no-store forward back navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update histograms.xml and add another histogram Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_handle_impl.cc

diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc

index 47dc9a23962c4e42ceaede2f50cd7418f4283fe0..9fcf44e274af71ca7eef9746d3eafe5934c2f1da 100644

--- a/content/browser/frame_host/navigation_handle_impl.cc

+++ b/content/browser/frame_host/navigation_handle_impl.cc

@@ -206,7 +206,8 @@ bool NavigationHandleImpl::IsSamePage() {

}

const net::HttpResponseHeaders* NavigationHandleImpl::GetResponseHeaders() {

- return response_headers_.get();

+ DCHECK_GE(state_, WILL_REDIRECT_REQUEST);

+ return response_headers_.get();

}

bool NavigationHandleImpl::HasCommitted() {

« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.h ('k') | content/public/browser/navigation_handle.h » ('j') | no next file with comments »