Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2174403002: [Extensions Histograms] Update ExtensionBubbleAction enum (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Histograms] Update ExtensionBubbleAction enum We added a new value for extension bubble actions for dismissing by deactivation in crrev.com/486b20e71bb481cf6ae6491a998aa252081a8833 in November, but never updated the histogram entry. As a result, the data, while recording correctly, shows "3" for dismissing by deactivation. Update the histogram file to correct this. BUG=None Committed: https://crrev.com/c1144734513b4607d9b21ef21040a5ebc1bb1381 Cr-Commit-Position: refs/heads/master@{#407567}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -1 line 3 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
Ilya, mind taking a look? https://codereview.chromium.org/2174403002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2174403002/diff/1/tools/metrics/histograms/histograms.xml#newcode73077 tools/metrics/histograms/histograms.xml:73077: + <int value="2" label="Dismiss ...
4 years, 5 months ago (2016-07-25 16:21:31 UTC) #2
Ilya Sherman
LGTM https://codereview.chromium.org/2174403002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2174403002/diff/1/tools/metrics/histograms/histograms.xml#newcode73077 tools/metrics/histograms/histograms.xml:73077: + <int value="2" label="Dismiss by user action"/> On ...
4 years, 5 months ago (2016-07-25 18:43:50 UTC) #3
Devlin
https://codereview.chromium.org/2174403002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2174403002/diff/1/tools/metrics/histograms/histograms.xml#newcode73077 tools/metrics/histograms/histograms.xml:73077: + <int value="2" label="Dismiss by user action"/> On 2016/07/25 ...
4 years, 5 months ago (2016-07-25 18:45:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174403002/1
4 years, 5 months ago (2016-07-25 18:46:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 20:40:28 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 20:42:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1144734513b4607d9b21ef21040a5ebc1bb1381
Cr-Commit-Position: refs/heads/master@{#407567}

Powered by Google App Engine
This is Rietveld 408576698