Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2174403002: [Extensions Histograms] Update ExtensionBubbleAction enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index e4d580d2c53cc2a576d29fb24bef4dff168cdb4d..e093bb33465134b7f934ba1a6f15551ff6a38006 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -73074,7 +73074,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<enum name="ExtensionBubbleAction" type="int">
<int value="0" label="Learn more"/>
<int value="1" label="Execute"/>
- <int value="2" label="Dismiss"/>
+ <int value="2" label="Dismiss by user action"/>
Devlin 2016/07/25 16:21:31 These are just labels, and changing the text won't
Ilya Sherman 2016/07/25 18:43:50 Correct, as long as "Dismiss" previously meant "Di
Devlin 2016/07/25 18:45:42 It did. We were recording all values; "3" just di
+ <int value="3" label="Dismiss by deactivation"/>
</enum>
<enum name="ExtensionCreationFlags" type="int">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698