Move filtering logic in GetDataListSuggestions() to Blink.

Move filtering logic in GetDataListSuggestions() to Blink.

Add blink::WebInputElement::filteredDataListOptions(), and it implements the
filtering logic which was in GetDataListSuggestions().
The logic should be in Blink because it affects a web-platform behavior.

This CL doesn't have behavior changes.

BUG=153991
Committed: https://crrev.com/7b8a38bd4485221cc71355c22e86c3e4c5b2a970
Cr-Commit-Position: refs/heads/master@{#407709}

[tkent, 2016-07-25 12:34:36]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 12:34:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-07-25 13:19:35]

tkent@chromium.org changed reviewers:
+ isherman@chromium.org, vabr@chromium.org

[tkent, 2016-07-25 13:19:36]

isherman@, or vabr@, would you review this please?
This is a preparation for crbug.com/153991 and crbug.com/607097.

[commit-bot: I haz the power, 2016-07-25 13:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 13:43:31]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-07-25 13:59:53]

LGTM, thanks!
Vaclav

https://codereview.chromium.org/2174303002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebInputElementTest.cpp (right):

https://codereview.chromium.org/2174303002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebInputElementTest.cpp:30:
std::unique_ptr<DummyPageHolder> m_pageHolder;
nit: #include <memory> for the unique_ptr?

[tkent, 2016-07-25 14:13:08]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 14:13:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-07-25 14:17:52]

Description was changed from

==========
Move filtering logic in GetDataListSuggestions() to Blink.

Add blink::WebInputElement::filteredDataListOptions(), and it implements the
filtering logic in GetDataListSuggestions().
The logic should be in Blink because it affects a web-platform behavior.

This CL doesn't have behavior changes.

BUG=153991
==========

to

==========
Move filtering logic in GetDataListSuggestions() to Blink.

Add blink::WebInputElement::filteredDataListOptions(), and it implements the
filtering logic which was in GetDataListSuggestions().
The logic should be in Blink because it affects a web-platform behavior.

This CL doesn't have behavior changes.

BUG=153991
==========

[dglazkov, 2016-07-25 14:26:40]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org, esprehn@chromium.org, haraken@chromium.org

[dglazkov, 2016-07-25 14:26:41]

I think this move is great start, but WebInputElement is not the final resting
place. Ideally, this logic should just go into HTMLInputElement and be plumbed
through to the WebInputElement. One day, we are going to get rid of the
WebElement* \o/

[commit-bot: I haz the power, 2016-07-25 16:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 16:06:20]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-07-26 00:29:28]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 00:30:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-07-26 01:53:40]

On 2016/07/25 at 14:26:41, dglazkov wrote:
> I think this move is great start, but WebInputElement is not the final resting
place. Ideally, this logic should just go into HTMLInputElement and be plumbed
through to the WebInputElement. One day, we are going to get rid of the
WebElement* \o/

Yes.  I implemented it in WebInputElement because I thought implementation in
HTMLInputElement needed an extra vector copy.  However, I found such extra copy
wasn't necessary.  Patch Set 3 moved the implementation to HTMLInputElement.

[commit-bot: I haz the power, 2016-07-26 03:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 03:05:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-07-26 03:07:14]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-07-26 03:07:15]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2174303002/#ps40001
(title: "Move implementation to HTMLInputElement")

[commit-bot: I haz the power, 2016-07-26 03:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 04:39:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-26 04:40:37]

Description was changed from

==========
Move filtering logic in GetDataListSuggestions() to Blink.

Add blink::WebInputElement::filteredDataListOptions(), and it implements the
filtering logic which was in GetDataListSuggestions().
The logic should be in Blink because it affects a web-platform behavior.

This CL doesn't have behavior changes.

BUG=153991
==========

to

==========
Move filtering logic in GetDataListSuggestions() to Blink.

Add blink::WebInputElement::filteredDataListOptions(), and it implements the
filtering logic which was in GetDataListSuggestions().
The logic should be in Blink because it affects a web-platform behavior.

This CL doesn't have behavior changes.

BUG=153991

Committed: https://crrev.com/7b8a38bd4485221cc71355c22e86c3e4c5b2a970
Cr-Commit-Position: refs/heads/master@{#407709}
==========

[commit-bot: I haz the power, 2016-07-26 04:40:39]

Patchset 3 (id:??) landed as
https://crrev.com/7b8a38bd4485221cc71355c22e86c3e4c5b2a970
Cr-Commit-Position: refs/heads/master@{#407709}

[dglazkov, 2016-07-26 04:51:22]

On 2016/07/26 at 04:40:39, commit-bot wrote:
> Patchset 3 (id:??) landed as
https://crrev.com/7b8a38bd4485221cc71355c22e86c3e4c5b2a970
> Cr-Commit-Position: refs/heads/master@{#407709}

\o/

[vabr (Chromium), 2016-07-26 12:05:03]

Still LGTM, just 2 post-landing optional nits.
Cheers,
Vaclav

https://codereview.chromium.org/2174303002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLInputElement.h (right):

https://codereview.chromium.org/2174303002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLInputElement.h:211: // Associated
<datalsit> options which match to the current INPUT value.
typo: datalsit -> datalist

https://codereview.chromium.org/2174303002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebInputElement.h (right):

https://codereview.chromium.org/2174303002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebInputElement.h:80: // Associated <datalsit>
options which match to the current INPUT value.
typo: datalsit -> datalist

[tkent, 2016-07-27 03:55:14]

oops, will fix typos.