NonValidatingReload: Monitor reload operations in NavigationControllerImpl

content/browser/frame_host/navigation_entry_impl.h

Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index e76f391ad6cceff250cf72f4c7f2e3ccc6d2675b..3541886c976e8492e8f9e6250e563bc23af8f3c1 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -19,6 +19,7 @@
 #include "content/common/resource_request_body_impl.h"
 #include "content/public/browser/favicon_status.h"
 #include "content/public/browser/global_request_id.h"
+#include "content/public/browser/navigation_controller.h"

[Charlie Reis, 2016/08/08 23:57:54]

We've tried hard to avoid having a circular dependency between
NavigationController and NavigationEntry.  If we continue down this path, maybe
we can put ReloadType into a file of its own.

[Takashi Toyoshima, 2016/08/09 12:06:17]

Oh, is this why we have another RestoreType enum in NavigationEntry?
Let me make a separate change to solve this and RestoreType.
Probably, I'd make public/browser/navigation_types.h to have both two types.

[Charlie Reis, 2016/08/10 05:05:13]

I think this may be getting ahead of ourselves.  I'm not convinced yet that we
want to add this to NavigationEntry, given the problems I mentioned below.

 #include "content/public/browser/navigation_entry.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/ssl_status.h"
@@ -329,6 +330,13 @@ class CONTENT_EXPORT NavigationEntryImpl
     return restore_type_;
   }
 
+  void set_reload_type(NavigationController::ReloadType type) {
+    reload_type_ = type;
+  }
+  NavigationController::ReloadType reload_type() const {
+    return reload_type_;
+  }
+
   void set_transferred_global_request_id(
       const GlobalRequestID& transferred_global_request_id) {
     transferred_global_request_id_ = transferred_global_request_id;
@@ -523,6 +531,8 @@ class CONTENT_EXPORT NavigationEntryImpl
   bool has_user_gesture_;
 #endif
 
+  NavigationController::ReloadType reload_type_;
+
   // Used to store extra data to support browser features. This member is not
   // persisted, unless specific data is taken out/put back in at save/restore
   // time (see TabNavigation for an example of this).