NonValidatingReload: Monitor reload operations in NavigationControllerImpl

content/browser/frame_host/navigation_entry_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/frame_navigation_entry.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/common/frame_message_enums.h"
 #include "content/common/resource_request_body_impl.h"
 #include "content/public/browser/favicon_status.h"
 #include "content/public/browser/global_request_id.h"
+#include "content/public/browser/navigation_controller.h"

[Charlie Reis, 2016/08/08 23:57:54]

We've tried hard to avoid having a circular dependency between
NavigationController and NavigationEntry.  If we continue down this path, maybe
we can put ReloadType into a file of its own.

[Takashi Toyoshima, 2016/08/09 12:06:17]

Oh, is this why we have another RestoreType enum in NavigationEntry?
Let me make a separate change to solve this and RestoreType.
Probably, I'd make public/browser/navigation_types.h to have both two types.

[Charlie Reis, 2016/08/10 05:05:13]

I think this may be getting ahead of ourselves.  I'm not convinced yet that we
want to add this to NavigationEntry, given the problems I mentioned below.

 #include "content/public/browser/navigation_entry.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/ssl_status.h"
 
 namespace content {
 class ResourceRequestBodyImpl;
 struct CommonNavigationParams;
 struct RequestNavigationParams;
 struct StartNavigationParams;
 
@@ skipping 290 matching lines @@
 
   // The RestoreType for this entry. This is set if the entry was retored. This
   // is set to RESTORE_NONE once the entry is loaded.
   void set_restore_type(RestoreType type) {
     restore_type_ = type;
   }
   RestoreType restore_type() const {
     return restore_type_;
   }
 
+  void set_reload_type(NavigationController::ReloadType type) {
+    reload_type_ = type;
+  }
+  NavigationController::ReloadType reload_type() const {
+    return reload_type_;
+  }
+
   void set_transferred_global_request_id(
       const GlobalRequestID& transferred_global_request_id) {
     transferred_global_request_id_ = transferred_global_request_id;
   }
 
   GlobalRequestID transferred_global_request_id() const {
     return transferred_global_request_id_;
   }
 
   // Whether this (pending) navigation needs to replace current entry.
@@ skipping 54 matching lines @@
  private:
   // Finds the TreeNode associated with |frame_tree_node|, if any.
   NavigationEntryImpl::TreeNode* FindFrameEntry(
       FrameTreeNode* frame_tree_node) const;
 
   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
   // Session/Tab restore save portions of this class so that it can be recreated
   // later. If you add a new field that needs to be persisted you'll have to
   // update SessionService/TabRestoreService and Android WebView
   // state_serializer.cc appropriately.
   // For all new fields, update |Clone| and possibly |ResetForCommit|.

[Charlie Reis, 2016/08/08 23:57:54]

Please see this warning about adding things to NavigationEntry.

In general, we try to avoid it.  :)  It's a little easier if the data can be
cleared at commit time and doesn't need to be persisted across sessions, but we
need to think carefully about it either way.

[Takashi Toyoshima, 2016/08/09 12:06:17]

Oh, I didn't notice this WARNING.
So, at the next change, I just add a copy code in |Clone| tentatively.
If it's possible to reset reload_type_ at the commit time, I'll revisit this
again. But it will be after discussing ClientRedirectPolicy plumbing.

[Charlie Reis, 2016/08/10 05:05:13]

I don't think it's safe to add something that isn't persisted and isn't cleared
at commit time.

   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
 
   // Tree of FrameNavigationEntries, one for each frame on the page.
   // TODO(creis): Once FrameNavigationEntries can be shared across multiple
   // NavigationEntries, we will need to update Session/Tab restore.  For now,
   // each NavigationEntry's tree has its own unshared FrameNavigationEntries.
   std::unique_ptr<TreeNode> frame_tree_;
 
   // See the accessors above for descriptions.
   int unique_id_;
@@ skipping 99 matching lines @@
 
 #if defined(OS_ANDROID)
   // The time at which Chrome received the Android Intent that triggered this
   // URL load operation. Reset at commit and not persisted.
   base::TimeTicks intent_received_timestamp_;
 
   // Whether the URL load carries a user gesture.
   bool has_user_gesture_;
 #endif
 
+  NavigationController::ReloadType reload_type_;
+
   // Used to store extra data to support browser features. This member is not
   // persisted, unless specific data is taken out/put back in at save/restore
   // time (see TabNavigation for an example of this).
   std::map<std::string, base::string16> extra_data_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_